Enable writings node.js buffers directly #680
Conversation
| @@ -73,6 +73,6 @@ | |||
| }, | |||
| "typings": "./index.d.ts", | |||
| "dependencies": { | |||
| "follow-redirects": "1.0.0" | |||
| "follow-redirects": "0.0.7" | |||
There was a problem hiding this comment.
Why is this necessary?
|
Sorry, I believe the downgrade was because I ran into a serious regression w/ the updated follow-redirects dependency and updated my master branch of my fork. Using the updated follow-redirects causes this reported write after end issue: follow-redirects/follow-redirects#50 - which I was hitting in the component using my axios fork. I haven't had time to investigate that dependency defect further. |
|
#623 - I see there's already some awareness of the problem with follow-redirects as well. |
|
I'm also running into the problem with follow-redirects. Setting |
|
It looks like the problem with follow-redirects was fixed in 1.1.0 but axios locks down the version to 1.0.0. |
|
Sorry but we've finally merged #773 as it seemed more complete. Thanks for your contribution. |
|
@rubennorte what about the issue with follow-redirects? Should that be opened as a separate PR? |
|
@jcready yes please |
Hi there,
I ran into encoding problems with binary request string data (gzipped payloads) being transformed via Buffer.toString('utf8') in transformRequest.
This PR will enable passing in node buffers directly instead of needing to create a stream or copy to an ArrayBuffer just for the sake of sending compressed data.