[WIP] Map component#3755
Draft
Vuelos wants to merge 5 commits into
Draft
Conversation
Member
|
Good job! minor thing, I would increase the map size |
Helias
reviewed
May 15, 2026
| @Component({ | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| selector: 'keira-map-viewer', | ||
| standalone: true, |
Member
There was a problem hiding this comment.
Suggested change
| standalone: true, |
Helias
reviewed
May 15, 2026
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| selector: 'keira-map-viewer', | ||
| standalone: true, | ||
| imports: [CommonModule], |
Member
There was a problem hiding this comment.
do not import CommonModule, imports directly the components that are exposed by CommonModule and that you are using
Helias
reviewed
May 16, 2026
| import { TableRow } from '@keira/shared/constants'; | ||
|
|
||
| export const MAP_CONFIG = { | ||
| baseUrl: 'https://cdn.wowclassicdb.com/maps/', |
Member
There was a problem hiding this comment.
instead of cdn.wowclassicdb.com I would use wow.zamimg.com
https://wow.zamimg.com/images/wow/wrath/maps/
example: https://wow.zamimg.com/images/wow/wrath/maps/enus/normal/40.jpg
or wowgaming/aowow https://wowgaming.altervista.org/aowow/static/images/wow/maps/
We are using this on Keira3, or wow zamimg, so I would keep using it
Helias
reviewed
May 16, 2026
| import { inject, Injectable } from '@angular/core'; | ||
| import { MysqlQueryService } from '@keira/shared/db-layer'; | ||
| import { MAP_CONFIG, WorldMapArea } from './map-viewer.model'; | ||
| import { get } from 'jquery'; |
Member
There was a problem hiding this comment.
is it used? I would avoid importing jquery if possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds shared map component.
Partially vibecoded
Use the new component on Creatures and Gameobject Spawn components and on Quests preview panel.
Downloads the maps images from https://cdn.wowclassicdb.com/maps/ and caches them locally.
The logic for deciding what maps to show (As they overlap on coordinates) needs some revision.
Spawns:
Quest preview:
