Button for trace, schema on SQL Editor#3757
Open
Vuelos wants to merge 8 commits into
Open
Conversation
Helias
reviewed
May 15, 2026
| <td>{{ error.stack }}</td> | ||
| <td> | ||
| <button class="btn btn-primary btn-sm" (click)="showTrace = !showTrace"> | ||
| {{ showTrace ? 'Hide trace' : 'Show trace' }} |
Member
There was a problem hiding this comment.
we could use translations keys for these two strings
Helias
reviewed
May 15, 2026
Helias
reviewed
May 15, 2026
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Helias
reviewed
May 16, 2026
| this.schemaLoading.set(false); | ||
| }, | ||
| error: () => { | ||
| this.schemaLoading.set(false); |
Member
There was a problem hiding this comment.
you could move this into pipe finalize, ex.
.pipe(
...
finalize() => this.schemaLoading.set(false)
)and removing it from next and error
Helias
reviewed
May 16, 2026
| templateUrl: './query-error.component.html', | ||
| styleUrls: ['./query-error.component.scss'], | ||
| imports: [], | ||
| imports: [TranslateModule], |
Member
There was a problem hiding this comment.
do not use translate module, import the related directive or component that translate module is using (same of common module)
Today there is no reason to use modules in Angular
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button to show-hide trace: (used on SQL editor and DB login)
Load Tables and columns to schema (used on SQL Editor autocomplete)
