test: misc improvements to feature testing#3767
Open
FrancescoBorzi wants to merge 7 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds schema-sweep and error-toast tests to every editor, un-skips the two
selector tests that the Phase 0 helpers now make feasible, removes the stale
gameobject-template:176 skip (the targeted DOM no longer exists — type is
covered by the schema sweep via the inline keira-generic-option-selector
nested-<select> path), and fills in the missing selector-modal coverage:
ItemSelector, FactionSelector, FlagsSelector, MapSelector, AreaSelector,
SingleValueSelector across the relevant editors.
select-gameobject: assert GameobjectHandlerService.select is invoked with
(false, '<entry>', name) on result-row click.
sai-gameobject: integration test asserts GameobjectHandlerService.select
propagates to SaiGameobjectHandlerService with source_type: 1 (the
gameobject-specific SAI source type, distinct from Creature's 0) and that
the dirty rollup signal reflects SAI form changes.
gameobject-loot-template: render-presence tests for the warning alert when
gated off (type ∉ {3, 25}) and the keira-loot-editor element when gated on.
Brings the skipped-test count from 3 → 0 and adds 21 new tests; the suite
goes from 77 (74 + 3 skipped) to 98 passing.
Also adds libs/features/gameobject/TESTING.md documenting the
gameobject-specific gotchas (source_type=1, no modal selector-btn on
template, loot-template render gating, DB service routing per selector kind).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…elector-modal tests Adds 26 new tests to spell-dbc.component.integration.spec.ts: - schema-sweep walking every tab so each form control flows into the diff query - error-path test asserting an error toast on save failure - render-presence test for the EquippedItemSubclass conditional gate - 22 selector-modal tests covering Base, Flags, Items, and Effects tabs (single-value selectors, flag selectors, and item selectors with search) DispelType is the first in-tree caller of expectDiffQueryToUpdate. TestBed now provides KEIRA_APP_CONFIG_TOKEN so item selectors can resolve SqliteService transitively via IconService. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.