Fix requeue #16
Merged
Fix requeue #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ruby 2.1 to travis build.
Improve RetryExceptions middleware to support exception-dependent backoffs
Spawned from
This ensures that you’ll get an error if the job has already been cancelled, rather than resurrecting it.
Use qless core requeue
Retry and requeue callbacks
This ensures that you’ll get an error if the job has already been cancelled, rather than resurrecting it.
…ueue Conflicts: lib/qless/job.rb lib/qless/lua/qless-lib.lua lib/qless/lua/qless.lua
There was a problem hiding this comment.
Maybe it'd be worth DRYing this (this assumes that JSON.generate will handle primitives properly).
DEFAULT_OPTS = {
'priority' => 0,
'tags', => [],
# etc
}
def self.build_opts_array(opts)
DEFAULT_OPTS.reduce([opts.fetch(:delay, 0)]) do |result, (key, default)|
value = JSON.generate(opts.fetch(key.to_sym, default))
result << [key, value]
end
endIt'd be great if you could just slice out what you're interested in from the opts Hash and apply defaults for the missing values.
Author
There was a problem hiding this comment.
agreed a little unsure of it atm. had to stop work mid way through the branch =) picking up the work again today.
Author
There was a problem hiding this comment.
doesn't work with base types so sad =(
added 2 commits
May 8, 2015 12:32
There was a problem hiding this comment.
YMMV, but the benefit of Hash#fetch comes in when you expect the value in the Hash to be false or nil sometimes, otherwise, might as well do opts[:depends] || []
@jzaleski, I miss you 💋
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up enqueue option generation to make it less error prone, and easier to add new fields.