BFY-3692 stop printing failed jobs' stack traces in qless redis #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norepIy
reviewed
Oct 31, 2017
|
|
||
| # TODO: pull this out into a config option. | ||
| MAX_ERROR_MESSAGE_SIZE = 10_000 | ||
| MAX_ERROR_MESSAGE_SIZE = 100 |
There was a problem hiding this comment.
i don't remember what the AC was for that ticket but if the point is to keep just the type of error and look to splunk you could probably cut this down even more
Author
There was a problem hiding this comment.
Yeah, this just keeps the first 100 bytes of the error message. So if the code died because of raise SomeError.new("Hello"), "Hello" would get truncated to 100 bytes.
|
Do we have any tests that need to get updated for this? Otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of failed jobs create lots of stack traces that just take up needless space in redis, bringing it closer to OOMing, at the worst possible time --- when we would want to diagnose failed jobs! This PR eliminates stack traces from failed jobs in qless redis, forcing the user to look in splunk, where we should be looking for such things anyway.