Skip to content

Fix deprecations from Symfony debug #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theofidry merged 3 commits into from
Feb 16, 2022
Merged

Fix deprecations from Symfony debug #66

theofidry merged 3 commits into from
Feb 16, 2022

Conversation

@shyim
Copy link
Contributor

@shyim shyim commented Feb 16, 2022 

09:36:55 INFO      [php] User Deprecated: Method "Composer\Plugin\PluginInterface::activate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message.
[
  "exception" => ErrorException {
    #message: "User Deprecated: Method "Composer\Plugin\PluginInterface::activate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message."
    #code: 0
    #file: "./vendor/symfony/error-handler/DebugClassLoader.php"
    #line: 325
    #severity: E_USER_DEPRECATED
    trace: {
      ./vendor/symfony/error-handler/DebugClassLoader.php:325 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:295 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:486 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:103 { …}
      ./vendor/composer/composer/src/Composer/Factory.php:439 { …}
      ./src/Core/Framework/Plugin/Composer/Factory.php:19 {
        Shopware\Core\Framework\Plugin\Composer\Factory::createComposer(string $composerJsonDir, IOInterface $composerIO = null): Composer^
        › return (new ComposerFactory())->createComposer(
        ›     $composerIO,
        ›     $composerJsonDir . '/composer.json',
      }
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:113 { …}
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:41 { …}
      ./src/Core/Framework/Plugin/PluginService.php:85 { …}
      ./src/Core/Framework/Plugin/Command/PluginRefreshCommand.php:56 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:180 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:146 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./vendor/symfony/console/Application.php:1033 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
      ./vendor/symfony/console/Application.php:299 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
      ./vendor/symfony/console/Application.php:171 { …}
      ./bin/shopware:61 { …}
    }
  }
]
09:36:55 INFO      [php] User Deprecated: Method "Composer\Plugin\Capable::getCapabilities()" might add "array" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message.
[
  "exception" => ErrorException {
    #message: "User Deprecated: Method "Composer\Plugin\Capable::getCapabilities()" might add "array" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message."
    #code: 0
    #file: "./vendor/symfony/error-handler/DebugClassLoader.php"
    #line: 325
    #severity: E_USER_DEPRECATED
    trace: {
      ./vendor/symfony/error-handler/DebugClassLoader.php:325 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:295 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:486 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:103 { …}
      ./vendor/composer/composer/src/Composer/Factory.php:439 { …}
      ./src/Core/Framework/Plugin/Composer/Factory.php:19 {
        Shopware\Core\Framework\Plugin\Composer\Factory::createComposer(string $composerJsonDir, IOInterface $composerIO = null): Composer^
        › return (new ComposerFactory())->createComposer(
        ›     $composerIO,
        ›     $composerJsonDir . '/composer.json',
      }
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:113 { …}
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:41 { …}
      ./src/Core/Framework/Plugin/PluginService.php:85 { …}
      ./src/Core/Framework/Plugin/Command/PluginRefreshCommand.php:56 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:180 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:146 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./vendor/symfony/console/Application.php:1033 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
      ./vendor/symfony/console/Application.php:299 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
      ./vendor/symfony/console/Application.php:171 { …}
      ./bin/shopware:61 { …}
    }
  }
]
09:36:55 INFO      [php] User Deprecated: Method "Composer\Plugin\PluginInterface::deactivate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message.
[
  "exception" => ErrorException {
    #message: "User Deprecated: Method "Composer\Plugin\PluginInterface::deactivate()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message."
    #code: 0
    #file: "./vendor/symfony/error-handler/DebugClassLoader.php"
    #line: 325
    #severity: E_USER_DEPRECATED
    trace: {
      ./vendor/symfony/error-handler/DebugClassLoader.php:325 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:295 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:486 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:103 { …}
      ./vendor/composer/composer/src/Composer/Factory.php:439 { …}
      ./src/Core/Framework/Plugin/Composer/Factory.php:19 {
        Shopware\Core\Framework\Plugin\Composer\Factory::createComposer(string $composerJsonDir, IOInterface $composerIO = null): Composer^
        › return (new ComposerFactory())->createComposer(
        ›     $composerIO,
        ›     $composerJsonDir . '/composer.json',
      }
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:113 { …}
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:41 { …}
      ./src/Core/Framework/Plugin/PluginService.php:85 { …}
      ./src/Core/Framework/Plugin/Command/PluginRefreshCommand.php:56 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:180 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:146 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./vendor/symfony/console/Application.php:1033 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
      ./vendor/symfony/console/Application.php:299 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
      ./vendor/symfony/console/Application.php:171 { …}
      ./bin/shopware:61 { …}
    }
  }
]
09:36:55 INFO      [php] User Deprecated: Method "Composer\Plugin\PluginInterface::uninstall()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message.
[
  "exception" => ErrorException {
    #message: "User Deprecated: Method "Composer\Plugin\PluginInterface::uninstall()" might add "void" as a native return type declaration in the future. Do the same in implementation "Bamarni\Composer\Bin\Plugin" now to avoid errors or add an explicit @return annotation to suppress this message."
    #code: 0
    #file: "./vendor/symfony/error-handler/DebugClassLoader.php"
    #line: 325
    #severity: E_USER_DEPRECATED
    trace: {
      ./vendor/symfony/error-handler/DebugClassLoader.php:325 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:295 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:486 { …}
      ./vendor/composer/composer/src/Composer/Plugin/PluginManager.php:103 { …}
      ./vendor/composer/composer/src/Composer/Factory.php:439 { …}
      ./src/Core/Framework/Plugin/Composer/Factory.php:19 {
        Shopware\Core\Framework\Plugin\Composer\Factory::createComposer(string $composerJsonDir, IOInterface $composerIO = null): Composer^
        › return (new ComposerFactory())->createComposer(
        ›     $composerIO,
        ›     $composerJsonDir . '/composer.json',
      }
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:113 { …}
      ./src/Core/Framework/Plugin/Util/PluginFinder.php:41 { …}
      ./src/Core/Framework/Plugin/PluginService.php:85 { …}
      ./src/Core/Framework/Plugin/Command/PluginRefreshCommand.php:56 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:180 { …}
      ./src/Core/Maintenance/System/Command/SystemInstallCommand.php:146 { …}
      ./vendor/symfony/console/Command/Command.php:298 { …}
      ./vendor/symfony/console/Application.php:1033 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:96 { …}
      ./vendor/symfony/console/Application.php:299 { …}
      ./vendor/symfony/framework-bundle/Console/Application.php:82 { …}
      ./vendor/symfony/console/Application.php:171 { …}
      ./bin/shopware:61 { …}
    }
  }
]

theofidry
theofidry reviewed Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@theofidry theofidry merged commit f7fb03e into bamarni:master Feb 16, 2022
@theofidry
Copy link
Collaborator

theofidry commented Feb 16, 2022

Released as part of 1.4.2!

@mimmi20 mimmi20 mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theofidry theofidry theofidry left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shyim @theofidry