Skip to content

Rewrite the tests #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theofidry merged 1 commit into from
Jul 6, 2022
Merged

Rewrite the tests #77

theofidry merged 1 commit into from
Jul 6, 2022

Conversation

@theofidry
Copy link
Collaborator

@theofidry theofidry commented Jul 6, 2022 •
edited
Loading

  • Remove removed property from the PHPUnit config file
  • Clarify the types in the tests
  • Make the tests more explicit
    • Introduced helper assertions
    • Remove the assert from the test command
  • Cleanup the generated directories after running the tests
  • No longer generate a new directory for each test run
  • Fix running the tests locally on OSX

@theofidry theofidry merged commit 80b2f1c into bamarni:master Jul 6, 2022
@theofidry theofidry deleted the feature/fix-local-tests branch July 6, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@theofidry