Skip to content

Prevent Parsing of attachments #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2017
Merged

Prevent Parsing of attachments #183

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55e9e24
Make sure to not decode subparts of an attachment
May 31, 2017
29ab05c
Syntax Error Fix
May 31, 2017
90a0fe0
Update Mailbox.php
May 31, 2017
b58966d
Remove unused variable
ian-otto Aug 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/PhpImap/Mailbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class Mailbox {
protected $imapParams = array();
protected $serverEncoding;
protected $attachmentsDir = null;
protected $sDir = null;
Copy link
Owner

@barbushin barbushin Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this plz.

Copy link
Contributor Author

@ian-otto ian-otto Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What needs fixing? Not sure...

Copy link
Owner

@barbushin barbushin Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duper51 What is protected $sDir = null; for? It must be deleted.

protected $expungeOnDisconnect = true;
private $imapStream;

Expand Down Expand Up @@ -614,7 +615,7 @@ protected function initMailPart(IncomingMail $mail, $partStructure, $partNum, $m
}
if(!empty($partStructure->parts)) {
foreach($partStructure->parts as $subPartNum => $subPartStructure) {
if($partStructure->type == 2 && $partStructure->subtype == 'RFC822') {
if($partStructure->type == 2 && $partStructure->subtype == 'RFC822' && $partStructure->disposition !== "attachment") {
$this->initMailPart($mail, $subPartStructure, $partNum, $markAsSeen);
}
else {
Expand Down