feat(runner): Generic Extensions #268
Merged
+193
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the runner to make extensions type-driven using newly created extension traits built from the
BaseNodeConfig. Extensions can now be installed via a generic method:install_ext::<T>()(in the code snippet below we show this API change). In the node binary entrypoint, we now install extensions in this way - programmatically.To allow the flashblocks state to be shared through a
OnceCell, we moved this instantiation into theBaseNodeConfig, so this type can be cloned by the extensions during construction. This is a temporary solution which should be improved down the road.