Skip to content

Conversation

@madisoncarter1234
Copy link
Contributor

@madisoncarter1234 madisoncarter1234 commented Dec 10, 2025

Summary

Migrates flashblocks subscriptions from the base namespace to the eth namespace per #250.

Since no release has been cut with base_subscribe yet, this is a clean replacement with no backwards compatibility needed.

  • Rename BasePubSubApiEthPubSubApi (namespace: baseeth)
  • Rename BasePubSubEthPubSub
  • Rename BaseSubscriptionKindEthSubscriptionKind
  • Use replace_configured to override reth's existing eth_subscribe
  • Update all tests to use eth_subscribe/eth_unsubscribe

Usage

- method: "base_subscribe", params: ["newFlashblocks"]
+ method: "eth_subscribe", params: ["newFlashblocks"]

- method: "base_unsubscribe"
+ method: "eth_unsubscribe"

Test plan

  • All 18 flashblocks RPC tests pass
  • Release build succeeds

Closes #250

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 10, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

  Migrates flashblocks subscriptions from the base namespace to eth namespace
  per issue base#250. Since no release has been cut with base_subscribe yet,
  this is a clean replacement with no backwards compatibility needed.

  Changes:
  - Rename BasePubSubApi -> EthPubSubApi (namespace: base -> eth)
  - Rename BasePubSub -> EthPubSub
  - Rename BaseSubscriptionKind -> EthSubscriptionKind
  - Use replace_configured to override reth's existing eth_subscribe
  - Update all tests to use eth_subscribe/eth_unsubscribe

  Closes base#250
@madisoncarter1234 madisoncarter1234 force-pushed the feat/migrate-base-subscribe-to-eth branch from 0efce22 to 58c4468 Compare December 10, 2025 22:56
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Would appreciate second set of eyes from @danyalprout. Since we're using replace_configured on the module context, we shouldn't run into any namespace collision errors and the test suite should validate this behavior. Nice work @madisoncarter1234!

@madisoncarter1234
Copy link
Contributor Author

This looks good to me. Would appreciate second set of eyes from @danyalprout. Since we're using replace_configured on the module context, we shouldn't run into any namespace collision errors and the test suite should validate this behavior. Nice work @madisoncarter1234!

glad to help!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate base_subscribe to eth_subscribe

3 participants