feat(rpc): migrate base_subscribe to eth_subscribe #272
+42
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates flashblocks subscriptions from the
basenamespace to theethnamespace per #250.Since no release has been cut with
base_subscribeyet, this is a clean replacement with no backwards compatibility needed.BasePubSubApi→EthPubSubApi(namespace:base→eth)BasePubSub→EthPubSubBaseSubscriptionKind→EthSubscriptionKindreplace_configuredto override reth's existingeth_subscribeeth_subscribe/eth_unsubscribeUsage
Test plan
Closes #250