Offline deletion tool that searches and collects stale blocks#1134
Merged
Conversation
Contributor
Agree. Then, it's prerequisite (or recommended at least) to finish hinted handoff before running the scripts. |
Contributor
Author
|
Updated |
Contributor
|
Works nice 😄 |
borshop
added a commit
that referenced
this pull request
Apr 30, 2015
Offline deletion tool that searches and collects stale blocks Reviewed-by: shino
Contributor
|
@borshop merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #1124 . Changes since #1124 are:
oks-mode(compile).-loption for leeway; use start/end-mode(compile).Also, for fallbacks, I'd rather expect hinted handoff works and then delete with this tool. This is to prevent this script from being more complex, from operational mistake and from further bugs.