Skip to content

Fix missing xml fields on storage usage.#808

Merged
ksauzz merged 1 commit into
release/1.4from
bugfix/fix-xml-response-on-storage-stat
Feb 14, 2014
Merged

Fix missing xml fields on storage usage.#808
ksauzz merged 1 commit into
release/1.4from
bugfix/fix-xml-response-on-storage-stat

Conversation

@ksauzz
Copy link
Copy Markdown
Contributor

@ksauzz ksauzz commented Feb 13, 2014

Problem: Storage usage api responds 500 internal error on xml request.
Fix: Add missing supported xml fields to the definitions.
Reported by: #797

This PR includes:

  • update supported xml fields
  • add riak_test to xml response on storage usage.

Comment thread riak_test/tests/storage_stats_test.erl Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indent?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ksauzz ksauzz added this to the 1.4.5 milestone Feb 14, 2014
@ksauzz ksauzz added the Bug label Feb 14, 2014
@ksauzz ksauzz self-assigned this Feb 14, 2014
Comment thread riak_test/tests/storage_stats_test.erl Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this clause needed?

@shino
Copy link
Copy Markdown
Contributor

shino commented Feb 14, 2014

Source diff looks good, riak_test runs successfully. Nice!

I added some not important comments.

@shino
Copy link
Copy Markdown
Contributor

shino commented Feb 14, 2014

  • Eunit and eqc tests pass
  • Dialyzer output clean (no new warnings)
  • xref
  • riak_test tests pass

@shino
Copy link
Copy Markdown
Contributor

shino commented Feb 14, 2014

👍

- update supported xml fields
- add riak_test to xml response on storage usage.
- improve rtcs:datetime to more helpful format.
ksauzz added a commit that referenced this pull request Feb 14, 2014
…-stat

Fix missing xml fields on storage usage.
@ksauzz ksauzz merged commit 473cf3a into release/1.4 Feb 14, 2014
@ksauzz
Copy link
Copy Markdown
Contributor Author

ksauzz commented Feb 14, 2014

Thanks 🍫

@ksauzz ksauzz deleted the bugfix/fix-xml-response-on-storage-stat branch February 14, 2014 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants