This repository was archived by the owner on Feb 2, 2022. It is now read-only.
Runnnig under Anaconda envrionment, pillow requirement and invalid value to Gauge issue#136
Open
szmurlor wants to merge 8 commits intobastula:masterfrom
Open
Runnnig under Anaconda envrionment, pillow requirement and invalid value to Gauge issue#136szmurlor wants to merge 8 commits intobastula:masterfrom
szmurlor wants to merge 8 commits intobastula:masterfrom
Conversation
Owner
|
Thanks for the helpful PR! I will take a look and see if we can add this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been struggling a little with making the dicompyler run under Anaconda environment and just thought I could share my experiences.
Summary of this short pull request:
a) added pillow to requirements.txt as it is necessary to make properly work the 2dview.py plugin,
b) fixed an issue with incorrect Gauge value when the dicom tree was traversed,
c) added Anaconda environment file which can be easily used to create a fully eligible anaconda environment for running dicompiler (tested under Ubuntu 18.04 and Windows 10).
Hope this could improve the really great project!