Skip to content

Conversation

zozoens31
Copy link
Contributor

@zozoens31 zozoens31 commented May 11, 2021

This change is Reviewable

Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: LGTM missing from one of: pcorpet, Unresolved discussions (install.sh:r1 line 133)


install.sh, line 133 at r1 (raw file):

    curl -o "$TEMP_TGZ" -L "https://github.com/github/hub/releases/download/v${HUB_VERSION}/hub-${HUB_PLATFORM}-${HUB_VERSION}.tgz"
    tar -zxf "$TEMP_TGZ" -C "${DIR}" --strip-components 1 "hub-${HUB_PLATFORM}-${HUB_VERSION}"/bin
    tar -zxf "$TEMP_TGZ" -C "${DIR}" --strip-components 2 "hub-${HUB_PLATFORM}-${HUB_VERSION}"/share/man

Please check the installer hat is inside the tgz file

@zozoens31 zozoens31 enabled auto-merge (squash) May 11, 2021 12:37
Copy link
Contributor Author

@zozoens31 zozoens31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: LGTM missing from one of: pcorpet


install.sh, line 133 at r1 (raw file):

Previously, pcorpet (Pascal Corpet) wrote…

Please check the installer hat is inside the tgz file

Done.

Copy link
Member

@pcorpet pcorpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Tried on linux.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@zozoens31 zozoens31 merged commit 99af3ed into master May 11, 2021
@zozoens31 zozoens31 deleted the cyrille-hub branch May 18, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants