-
-
Notifications
You must be signed in to change notification settings - Fork 25
Remediate zizmor template injection issues #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kormide
merged 1 commit into
bazel-contrib:main
from
loosebazooka:zizmor-template-injection
Jun 9, 2025
Merged
Remediate zizmor template injection issues #278
kormide
merged 1 commit into
bazel-contrib:main
from
loosebazooka:zizmor-template-injection
Jun 9, 2025
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kormide
requested changes
Jun 5, 2025
9eea08f to
d11a934
Compare
kormide
reviewed
Jun 6, 2025
d11a934 to
d27a6f6
Compare
kormide
reviewed
Jun 6, 2025
This is not an exhaustive set of fixes for zizmor reported issues, just those related to github inputs/vars and template injection Signed-off-by: Appu Goundan <[email protected]>
d27a6f6 to
f2af329
Compare
Contributor
Author
|
wonder if I should just move all the inputs to the top as ENV for easier readability? |
kormide
approved these changes
Jun 9, 2025
Collaborator
kormide
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
|
@kormide whew, thanks for the checks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


This is not an exhaustive set of fixes for zizmor reported issues, just those related to github inputs/vars and template injection