Skip to content

Conversation

@loosebazooka
Copy link
Contributor

@loosebazooka loosebazooka commented Jun 3, 2025

This is not an exhaustive set of fixes for zizmor reported issues, just those related to github inputs/vars and template injection

@aspect-workflows
Copy link

aspect-workflows bot commented Jun 3, 2025

Test

All tests were cache hits

12 tests (100.0%) were fully cached saving 1m 28s.


Buildifier      Format      Lint [.]

@loosebazooka loosebazooka force-pushed the zizmor-template-injection branch from 9eea08f to d11a934 Compare June 5, 2025 15:56
@loosebazooka loosebazooka requested a review from kormide June 5, 2025 16:03
@loosebazooka loosebazooka force-pushed the zizmor-template-injection branch from d11a934 to d27a6f6 Compare June 6, 2025 14:27
This is not an exhaustive set of fixes for zizmor
reported issues, just those related to github inputs/vars
and template injection

Signed-off-by: Appu Goundan <[email protected]>
@loosebazooka loosebazooka force-pushed the zizmor-template-injection branch from d27a6f6 to f2af329 Compare June 6, 2025 17:10
@loosebazooka
Copy link
Contributor Author

wonder if I should just move all the inputs to the top as ENV for easier readability?

Copy link
Collaborator

@kormide kormide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested here and here.

@kormide kormide merged commit 79e6de0 into bazel-contrib:main Jun 9, 2025
3 of 5 checks passed
@loosebazooka
Copy link
Contributor Author

@kormide whew, thanks for the checks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants