Add author_{name,email} and committer_{name,email} Inputs #279
+26
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yannic
approved these changes
Jun 20, 2025
kormide
requested changes
Jun 22, 2025
Collaborator
kormide
left a comment
kormide
left a comment
There was a problem hiding this comment.
Thanks! Looks good, just a few nits for the descriptions.
Collaborator
|
Also, could you follow the pattern of putting the inputs into env vars as was done here? I think it's to satisfy some security tooling. |
Yannic
approved these changes
Jun 24, 2025
|
CI is read in this PR because the PR comes from a fork. #280 pushed the same changes to a branch in this repo and CI is happy |
kormide
approved these changes
Jun 24, 2025
Collaborator
kormide
left a comment
kormide
left a comment
There was a problem hiding this comment.
LGTM. I have some manual tests that I run for the workflow because it doesn't have integration testing yet. I'll run those today then merge.
Collaborator
Collaborator
Contributor
Author
Yannic
changed the title
|
I took the liberty to remove |
|
Pushed v0.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently needed to change the
AUTHOR_NAMEandAUTHOR_EMAILwith which an internal bot triggers a PR to our BCR fork and therefore the commit that eventually lands to https://github.com/bazelbuild/bazel-central-registryIt probably makes sense to make these two inputs instead of hardcoded.