Make is_windows public
#584
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all supported Bazel versions correctly validate the visibility of a private attribute relative to the definition of the rule rather than the target.
fmeum
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
Contributor
Author
|
@meteorcloudy Could we get an 1.8.1 release for this? |
dws
added a commit
to dws/rules_ts
that referenced
this pull request
Jul 5, 2025
As an experiment, we here patch bazel_skylib 1.8.0 with bazelbuild/bazel-skylib#584 in order to see if this resolves a problem that we're seeing with Bazel 6.5.0.
meteorcloudy
approved these changes
Jul 7, 2025
Member
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all supported Bazel versions correctly validate the visibility of a private attribute relative to the definition of the rule rather than the target.