Explicitly set the tar format to GNU.#601
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Jul 19, 2022
Merged
Conversation
This means that: 1. you'll get the same format no matter what version of Python you have. At Python 3.8 the default changed from GNU to PAX. 2. The default will be suitable for building Debian packages containing long file names. A followup PR may add the capability to allow PAX tar writing, but I do not know the urgency of that at this time, so that is a future feature request. Fixes bazelbuild#216
nacl
approved these changes
Jul 19, 2022
Collaborator
nacl
left a comment
nacl
left a comment
There was a problem hiding this comment.
It probably be worth adding in some testers that use the newer version of python so we can confirm that everything is happy there. Ubuntu 20.04 may be enough here.
Collaborator
Author
|
I started a set of tests but it became meaningless quickly because it was not clear what my goals were. What I think I need is the kind of long file name that would be different in each of the tar formats, and then to see that they make valid .deb files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that:
At Python 3.8 the default changed from GNU to PAX.
long file names.
A followup PR may add the capability to allow PAX tar writing, but I
do not know the urgency of that at this time, so that is a future
feature request.
Fixes #216