-
Notifications
You must be signed in to change notification settings - Fork 287
Docs: update for RGBW neopixel #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: update for RGBW neopixel #694
Conversation
Co-authored-by: Carlos Pereira Atencio <[email protected]>
Co-authored-by: Carlos Pereira Atencio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V2 also has fill and clear, could you check if those are available for V1 as well?
https://github.com/microbit-foundation/micropython-microbit-v2/blob/6a4b97ffce97a41a593e77553a82e24e59b7107c/src/codal_port/modules/neopixel.py
Co-authored-by: Carlos Pereira Atencio <[email protected]>
|
V1 has |
|
I've updated to add the V2 methods in 9641853 Not sure on how best to present Also not sure on how to present arguments for |
Yeah, they are equivalent. The current text is good, although if you need to edit the file anyway I might remove
Showing the tuple would be difficult, as the length depends on how many bytes per pixel. I think it's fine to just name the argument |
|
Perfect, thanks Mark! |
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
Based on the changes added to the V2 documentation from PR bbcmicrobit#694 Co-authored-by: Carlos Pereira Atencio <[email protected]>
Based on the changes added to the V2 documentation from PR bbcmicrobit#694 Co-authored-by: Carlos Pereira Atencio <[email protected]>
Based on the changes added to the V2 documentation from PR bbcmicrobit#694 Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* docs: Update V1 neopixel module support for RGBW. Based on the changes added to the V2 documentation from PR #694 Co-authored-by: Carlos Pereira Atencio <[email protected]> * docs: Fix typo in NeoPixel module. Co-authored-by: Mark <[email protected]> Co-authored-by: Mark <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
* Docs: update for RGBW neopixel * Docs: RGBW neopixels * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * change to bpp * change to bpp * add image attribution * Update docs/neopixel.rst Co-authored-by: Carlos Pereira Atencio <[email protected]> * Add V2 methods * Docs: Update neopixel Co-authored-by: Carlos Pereira Atencio <[email protected]>
Doc update to include support for RGBW Neopixels. I haven't tested this on hardware, so making an assumption that the values are in the order written eg
np[0]= (R, G, B, W)as opposed to GRBW which I think is the default for NeoPixelsand we order them here https://github.com/microbit-foundation/micropython-microbit-v2/blob/6a4b97ffce97a41a593e77553a82e24e59b7107c/src/codal_port/modules/neopixel.py#L19