-
Notifications
You must be signed in to change notification settings - Fork 287
docs: Add Power Management documentation. #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
57ad425
docs: Add Power Management documentation.
microbit-carlos a72b2d7
docs: Merge the wake_source() function into deep_sleep().
microbit-carlos 0825744
docs: Merge power.deep_sleep() `pins` & `buttons` params into `wake_on`.
microbit-carlos 42db7bc
docs: Move power examples to Python files, and the tech details to th…
microbit-carlos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docs: Merge the wake_source() function into deep_sleep().
- Loading branch information
commit a72b2d78dce3a07c279045b2a7d554db507ee104
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinsandbuttonscould actually be combined into, eg,events. Because the code can check the type of the objects passed in. Egdeep_sleep(events=(button_a, pin0)).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, having the buttons for only 2 options doesn't feel quite right. Although I'm not 100% sure about the word
eventsthough, it doesn't feel very obviousdeep_sleep(events=(pin1,pin2)), but it's warming up on me.Do you think using
pinsand include buttons in the same argument would be confusing?deep_sleep(pins=(pin1, button_a))There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
wake_onorwake_by? Egdeep_sleep(wake_on=(pin1, button_a)).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wake_onsounds good 👍Added in 0825744.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now implemented.