docs: Rename SoundEffect wave to waveform #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-carlos
changed the title
microbit-carlos
commented
Sep 6, 2022
| :param vol_end: End volume value, range 0-255, default: ``0`` | ||
| :param wave: Type of wave shape, one of these values: ``WAVE_SINE``, | ||
| ``WAVE_SAWTOOTH``, ``WAVE_TRIANGLE``, ``WAVE_SQUARE``, | ||
| :param waveform: Type of waveform shape, one of these values: |
Member
There was a problem hiding this comment.
I suggest we then also change the constants to WAVEFORM_SAWTOOTH etc.
Collaborator
Author
There was a problem hiding this comment.
I was a bit hesitant to make these constants even longer, but it makes sense to keep the same name, so I've updated the PR for the constants to start with WAVEFORM_.
Member
There was a problem hiding this comment.
I think consistency is important here.
4 tasks
microbit-carlos
force-pushed
the
docs-soundeffect
branch
from
d7f0227 to
b8c461c
Compare
microbit-carlos
changed the title
Collaborator
Author
|
@dpgeorge I've separated the predefined sounds out of this PR into a new one, as we won't have time to implement these before the v2.1.0 release: This PR now only contains the |
microbit-carlos
force-pushed
the
docs-soundeffect
branch
from
b8c461c to
a569258
Compare
Member
|
This change has now been made in the v2 code. |
Collaborator
Author
|
I'll merge this, as it has been released with the v2.1.0-beta.3. |
microbit-carlos
added a commit
that referenced
this pull request
Nov 15, 2022
microbit-carlos
added a commit
to microbit-carlos/micropython
that referenced
this pull request
Feb 26, 2024
microbit-carlos
added a commit
that referenced
this pull request
Feb 26, 2024
microbit-carlos
added a commit
that referenced
this pull request
May 7, 2024
microbit-carlos
added a commit
that referenced
this pull request
Jul 18, 2024
microbit-carlos
added a commit
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://microbit-micropython--765.org.readthedocs.build/en/765/audio.html