Skip to content

Add watchlist export#4

Open
frm wants to merge 2 commits intobbeesley:mainfrom
frm:master
Open

Add watchlist export#4
frm wants to merge 2 commits intobbeesley:mainfrom
frm:master

Conversation

@frm
Copy link

@frm frm commented Dec 30, 2018

Hey!

I don't know if you want this but since Letterboxd allows you to import a watchlist, I tweaked your code to allow exporting the trakt watchlist as well.

It's triggered by adding a -w flag.

screenshot 2018-12-30 at 16 59 48

@bbeesley bbeesley self-requested a review as a code owner November 9, 2019 18:40
@bbeesley
Copy link
Owner

bbeesley commented Nov 9, 2019

Hey man, sorry, I realised I'm like a year late on this 😂I had notifications turned off on this repo for some reason.
Anyway, if you're still interested, happy for this to be merged, but the commit message needs changing for the automated release pipeline to properly version the new package. It's using conventional commits, so your commit message needs to be something like feat: add support for watchlist export. So if you rebase, reword the commit, and push it back up, assuming the tests are all good I'll merge it.

Copy link
Owner

@bbeesley bbeesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, looks good, just needs the commit message to be changed.

@frm
Copy link
Author

frm commented Nov 12, 2019

Oh wow, I forgot about this. Yep, no worries 👍

@bbeesley
Copy link
Owner

looks like you still have a failing test mate

@frm
Copy link
Author

frm commented Sep 18, 2020

I reckon I might just have several now, given the updates to the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants