Conversation
Update observation context loader. Remove old page layouts, refactor general setup ---------
* Added a trash can icon next to each deployment in the Edit Deployment page. Does not appear on Add Deployment. * Clicking the trash can will prompt you with a confirm dialogue. Accepting the dialogue should hit an endpoint in bctw api and remove the deployment from the list. If no deployments remain, then the dialogue automatically closes. * Added verification of device make directly to the yup schema. Was sometimes missing changes to device id before with the previous set up, this seems more robust. * Added verification of conflicting deployment date ranges directly to yup schema. Similarly to device make, there were certain cases where this check would not happen before submitting the form. * Fixed some date range checking logic that was missing some overlapping cases, which allowed you to submit the form and get a 500 back. --------- Co-authored-by: jeznorth <twenty15creative@gmail.com> Co-authored-by: JeremyQuartech <jeremy.kissack@quartech.com> Co-authored-by: Curtis Upshall <curtisupshall@gmail.com> Co-authored-by: JeremyQuartech <123425360+JeremyQuartech@users.noreply.github.com>
* Add datagrid autocomplete components * Add datagrid support for sample site, method, and period columns * Add time component to data grid. * Added node-pg float type parser * Save/Edit datagrid observations working
See sampling sites that have been added to the manage observations interface. 1. User Sees Sampling Sites 2. User Expands and Collapses Sampling Site List Item Initial edit functionality for individual sampling sites. (Sample Location, Method, Period ) 1. User Edits Sampling Site
* Added a View Telemetry button to the actions menu for rows in the animal table. Only visible if animal has deployments. * When you click this, it will either show you a fullscreen map view of the telemetry points and tracks for this animal's deployments or show you a small dialog indicating that there are no points to show yet (most likely scenario for newly added critters). Additional bctw-service functions and routes to support grabbing this information from BCTW. * Points are grouped by deployment id. The deployment id is used to calculate the colour so it is consistent between re-renders. There is also an outline colour to help distinguish points that contrast poorly with the map.
…mary Results Components (#1117) * Removed import functionality for observations and summary results components. * Fixed minor issues with action toolbar (h2 toolbar was using an h4 element for the title). * Fixed language inconsistency with the 'Marked or Known Animals' interface.
* Refactored FloatingPointField component into more flexible CustomNumberField that adds integer support. * Added more constraints to telemetry device schema to better align with BCTW API limitations. * Added logic to reduce unnecessary calls to BCTW API from survey animals page.
* Add missing authorization check for project permission. * Fix funding source endpoint only returning data for system admins. * Changed authorization to 'SystemUser' for all basic critterbase lookup and xref endpoint * Removed duplicate / unused critter-data API endpoints * Misc cleanup Co-authored-by: JeremyQuartech <jeremy.kissack@quartech.com>
|
Openshift URLs for the PR Deployment: |
NickPhura
requested review from
GrahamS-Quartech,
JeremyQuartech,
KjartanE,
MacDeluca,
al-rosenthal,
curtisupshall and
jeznorth
Codecov Report
@@ Coverage Diff @@
## test #1123 +/- ##
==========================================
- Coverage 63.29% 63.10% -0.20%
==========================================
Files 531 536 +5
Lines 15776 16326 +550
Branches 2437 2510 +73
==========================================
+ Hits 9985 10302 +317
- Misses 5105 5333 +228
- Partials 686 691 +5
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KjartanE
approved these changes
Oct 17, 2023
Contributor
KjartanE
left a comment
KjartanE
left a comment
There was a problem hiding this comment.
tested PR instance, all core functioning components acting appropriately
* Fix survey view date response * Fix unit test
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-308
Description of Changes
n/a
Testing Notes
Would be good to do a sanity check in the PR deployment, just to catch any small issues that are easy to fix before we merge.
Then we can merge, and do a deep dive in Test, to make sure any old data migrated correctly, and everything works as expected, and all of the connections to BCTW/Critterbase Test are happy.
If any issues are found in the PR deployment, we can include the fixes in this PR: #1124