Release dev-staging changes to dev#1131
Merged
Merged
Conversation
* Various survey page layout changes * Adds the ability to see added survey observations in a map view
|
Openshift URLs for the PR Deployment: |
curtisupshall
requested review from
GrahamS-Quartech,
KjartanE,
NickPhura and
al-rosenthal
curtisupshall
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1131 +/- ##
==========================================
- Coverage 63.16% 61.11% -2.06%
==========================================
Files 536 553 +17
Lines 16367 16774 +407
Branches 2516 2579 +63
==========================================
- Hits 10339 10251 -88
- Misses 5334 5845 +511
+ Partials 694 678 -16
... and 16 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
NickPhura
previously approved these changes
Oct 20, 2023
NickPhura
previously approved these changes
Oct 20, 2023
NickPhura
changed the title
* Minor Fixes / UI Tweaks * Fix permit component list key * Rename old sampling method form to sampling strategy Co-authored-by: Nick Phura <nickphura@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
* Add's UIs for uploading CSV files to survey observations * Adds a new database table to track survey observation CSV submissions, survey_observation_submission * Alters the survey_observation table to make optional the sampling site, method, and period columns * Adds service and repo methods for processing observation CSVs
* Survey Study area can now import files with multiple features * Drawn features can be created and saved to a survey * New card for displaying and editing map features * Region selector updated
* Adds Sampling Site record count to title area, Example: Sampling Sites (10) * Adds Observation record count to title area of observations map component and manage observations page, Example: Observations (10) * Adds 'supplementaryObservationData' section to get survey observations endpoint. This allows observation record counts to be displayed, even if the get observations response becomes paginated or virtualized at a later date
* Added some additional logic to the API to extract a name and description from the provided shape file when creating sampling sites. * It will search the keys of the geometry's properties for "name" or "label" and "des" or "desc" or "descr" (exact match), then use the value for the sampling site name and description respectively. * Added a character limit to the sampling site name field in the edit form. --------- Co-authored-by: JeremyQuartech <jeremy.kissack@quartech.com>
Map container removed in lieu of using the leaflet component Map css moved into single component Removed project location data --------- Co-authored-by: Nick Phura <nickphura@gmail.com> Co-authored-by: JeremyQuartech <jeremy.kissack@quartech.com> Co-authored-by: jeznorth <twenty15creative@gmail.com>
Removed field method and site selection strategies are now required on surveys
* Add delete sample site button to menu drop down * Check for any associated observations to sample site. * hook up api sample-site delete function. * SIMSBIOHUB-336/337 (#1142) * Adds Sampling Site record count to title area, Example: Sampling Sites (10) * Adds Observation record count to title area of observations map component and manage observations page, Example: Observations (10) * Adds 'supplementaryObservationData' section to get survey observations endpoint. This allows observation record counts to be displayed, even if the get observations response becomes paginated or virtualized at a later date * SIMSBIOHUB 343 - Incorrect date overlap error in sampling methods (#1144) * Fixed an issue where the yup schema used for editing sampling methods used the wrong field for a date overlap check. * Removed an unintended required(). * Added a refresh call when submitting sampling method changes so they are reflected in the UI. Otherwise you will still see the previous value if you go back to the sampling methods view even though the new value did save to the db. * SIMSBIOHUB-334/350/352 (#1143) * Added snackbar popup upon successfully saving observations. * Removed single-click to edit; Fixed bug that made row go into edit mode when clicking row delete icon. * Added seconds to the observation time * Clean up functions and excess data calls * fix tests --------- Co-authored-by: JeremyQuartech <123425360+JeremyQuartech@users.noreply.github.com> Co-authored-by: GrahamS-Quartech <112989452+GrahamS-Quartech@users.noreply.github.com> Co-authored-by: Curtis Upshall <curtisupshall@gmail.com>
…1152) * Added a migration that removes the intended_outcome_id column from the survey table and shifts the responsibility onto a join table called survey_intended_outcome. This makes it possible to have multiple intended outcomes associated with a single survey. * Modified the frontend and API to support this change. The dropdown in the add and edit forms for the survey have been replaced with a multiselect. Multiselect will still display the subtext associated with these elements. * In various cases where a single intended outcome was displayed before, they display as a comma deliminated list instead. * These items now display with the label of "Ecological Variables" in the frontend survey components.
* Modified each custom renderEditCell component of the ObservationTable to manually set hasFocus. This allows the user to Tab forward to the next cell or Shift+Tab back to the previous. * Wrapped some of the simpler TextField / DatePicker renders in their own functional components so that the same hasFocus pattern could be used.
…vey fields (#1158) * Replace existing survey list endpoint with index, which returns a subset of survey fields rather than all fields.
* Swap out old keycloak libraries for newer more up to date libraries. * Add RouteGuards tests. * Add git action to clean PR builds for PRs against non-base branches
…#1157) SIMSBIOHUB-354-355: Added sampling site and study area features to the observation map on the survey details page --------- Co-authored-by: Nick Phura <nickphura@gmail.com>
* Added a new ObservationTableContext * Added an endpont and repository methods to delete one or more observation records * Added loading button props to the YesNoDialog * Refactored the observation context to support deleting one or more observation records
#1161) * Moved the shapefile name and description extraction to UI. Modified the sampling site POST api to accept custom names and desc from UI. Implemented the same ability in study area submission, now both parts of the form can reference the same logic for extracting this info.
* Minor UI polish and updating notification content.
* Removes toLowerCase casting on user_identifier fields from keycloak and stores raw string value in the database regardless of case * Adds LOWER() sql statements on any relation to user_identifiers and user guids as to make them case-insensitive
Added time to periods in sampling sites --------- Co-authored-by: Alfred Rosenthal <alfred.k.rosenthal@gmail.com>
…ecords (#1165) * Seed script will now inject a survey sampling site with a corresponding method, period, and three observations.
* Adds the TaxonomyContext for caching taxonomy names from IDs * Updates the skeleton loader on the observations table * Adds backend caching for taxonomy name lookup * Updates service and repo methods for fetching observations supplementary data * Fixes a bug with updating the observation count upon deletion * Fixes a bug where deleted observation records would reappear when going back to the survey page after deletion * Adds a missing snackbar shown upon deletion * Adds the count of observtions being deleted in the confirm deletion dialog
|
Openshift URLs for the PR Deployment: |
curtisupshall
added
the
Early Feedback Welcome
curtisupshall
changed the title
Added a delete all button to study areas, updated map UI, added layer colors --------- Co-authored-by: jeznorth <twenty15creative@gmail.com>
curtisupshall
added
Ready For Review
|
SonarCloud Quality Gate failed.
|
NickPhura
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from
dev-staginghave already been reviewed.Links to Jira tickets