SIMSBIOHUB-445: Feature Branch - Consolidate Observations/Telemetry/Animals#1202
Conversation
|
Found one funny interaction, which could probably be fixed in a later PR: If you add a new record on the observation page, but then paginate to a new page, the UI gets into a funny state where the new row is gone, but the save/discard buttons are still active. Similar type issue with the validation banner remaining even though the new row is gone. |
Yeah that's an issue. We might not need to solve this if we add rows through a modal - or could solve it with a sticky row, if that ever becomes possible. Or we could even disable pagination entirely while the table is in "edit" mode. |
There was a problem hiding this comment.
Played with it a bit locally (not super exhaustively tbh). And gave the code a quick look over. Seems to function well. The endpoints look tightly defined which is great.
Not specifically about this PR, but in general:
One thing we should get into the habit of including in our OpenApi spec, is adding additionalProperties: false. Gets added as a sibling to the properties field in a type: object section. Just helps ensure over time that the openapi stays in sync with the response by making it more strict.
|
…nimals (#1202) * Combined the Telemetry and Observations map/table view on the Survey page, allowing users to toggle between them; * Added server-side support for paginating the observations fetching endpoint; * Modified the Manage Observations page to use server-side pagination; * Added a new endpoint to fetch all the spatial data relating to survey observations; * Deleted some old code related to Survey Summary Results.
* Adds survey sampling sites and study areas back to the Survey Map (since being removed by #1202); * Adds various popups to survey map features, showing various point/polygon metadata; * Removes extraneous observation table hook call; * Updates method names and documentation for telemetry API hooks.
* Adds survey sampling sites and study areas back to the Survey Map (since being removed by #1202); * Adds various popups to survey map features, showing various point/polygon metadata; * Removes extraneous observation table hook call; * Updates method names and documentation for telemetry API hooks.
* Adds survey sampling sites and study areas back to the Survey Map (since being removed by #1202); * Adds various popups to survey map features, showing various point/polygon metadata; * Removes extraneous observation table hook call; * Updates method names and documentation for telemetry API hooks.
6 participants
Links to Jira Tickets
Description of Changes
Testing Notes
You should be able to: