BHBC-2286/2266/2284/2271

[NickPhura]

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2284
https://quartech.atlassian.net/browse/BHBC-2266
https://quartech.atlassian.net/browse/BHBC-2286
https://quartech.atlassian.net/browse/BHBC-2271

Description of relevant changes

• {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-991-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-991-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=991

[codecov]

Codecov Report

Merging #991 (54abd28) into dev (3f3225e) will increase coverage by 2.08%.
The diff coverage is 34.52%.

@@            Coverage Diff             @@
##              dev     #991      +/-   ##
==========================================
+ Coverage   66.43%   68.52%   +2.08%     
==========================================
  Files         362      374      +12     
  Lines       11780    11669     -111     
  Branches     2014     1981      -33     
==========================================
+ Hits         7826     7996     +170     
+ Misses       3532     3227     -305     
- Partials      422      446      +24     

Impacted Files	Coverage Δ
api/src/models/survey-view.ts	100.00% <ø> (ø)
...aths/project/{projectId}/survey/{surveyId}/view.ts	95.83% <ø> (ø)
api/src/queries/queries.ts	100.00% <ø> (ø)
api/src/repositories/project-repository.ts	82.09% <ø> (-1.83%)	⬇️
app/src/components/publish/SubmitSection.tsx	15.00% <0.00%> (-0.79%)	⬇️
app/src/contexts/projectContext.tsx	12.50% <0.00%> (ø)
app/src/contexts/surveyContext.tsx	8.69% <0.00%> (-1.84%)	⬇️
...rojects/participants/ProjectParticipantsHeader.tsx	0.00% <0.00%> (ø)
.../projects/participants/ProjectParticipantsPage.tsx	0.00% <0.00%> (ø)
...jects/participants/ProjectParticipantsRoleMenu.tsx	0.00% <0.00%> (ø)
... and 59 more

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-991-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-991-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=991

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
2.4% Duplication

[KjartanE]

🐱