Skip to content

remove implementedEvents function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2016
Merged

remove implementedEvents function #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da725c3
remove implementedEvents function
styks1111 May 18, 2016
17499cb
remove test for implemented events
styks1111 May 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Controller/Component/ApiPaginationComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,6 @@ class ApiPaginationComponent extends Component
*/
protected $pagingInfo = [];

/**
* {@inheritDoc}
*
* @return array
*/
public function implementedEvents()
{
return [];
}

/**
* Injects the pagination info into the response if the current request is a
* JSON or XML request with pagination.
Expand Down
12 changes: 0 additions & 12 deletions tests/TestCase/Controller/Component/ApiPaginationComponentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,6 @@ public function tearDown()
parent::tearDown();
}

/**
* Simple test to check if implementedEvents returns an empty array.
*/
public function testImplementedEvents()
{
$apiPaginationComponent = new ApiPaginationComponent($this->controller->components());
$result = $apiPaginationComponent->implementedEvents();
$expected = [];

$this->assertSame($expected, $result);
}

/**
* Test that a non API or paginated request returns null.
*
Expand Down