Skip to content

Conversation

ishanvyas22
Copy link
Contributor

@ishanvyas22 ishanvyas22 commented Jun 21, 2023

Changelog

Fixed

  • Failing unit tests

Improved

  • Bump minimum CakePHP version to 4.2
  • Support for PHP 8.2
  • Replaced travis CI with Github Actions

@ishanvyas22
Copy link
Contributor Author

@bcrowe Can you please have a look at this?

@bcrowe
Copy link
Owner

bcrowe commented Jul 11, 2023

Hey, sorry for the delay! Let me take a look over this -- also I need to get the builds running again, not sure what happened there. Sit tight!

Edit: Oh, I see you took care of the CI build... thank you!

@bcrowe
Copy link
Owner

bcrowe commented Jul 11, 2023

I think my only question is, should we instead use ^4.2 & >=7.2 for the dependencies? Looks like PHP 8+ support started with 4.2. @ishanvyas22 @pabloelcolombiano

From what I see here: https://github.com/cakephp/cakephp/wiki#version-map

@bcrowe
Copy link
Owner

bcrowe commented Jul 11, 2023

One more thing. Maybe I'm missing something -- but wouldn't this continue to work fine on PHP 8+ and Cake 4.4, without needing to bump up the plugin's dependencies' versions? I don't think I see anything being introduced that isn't backwards compatible with 4.0 through 4.3. I guess I'm not seeing a need to release a new version of this that requires 4.4.

Although, it's definitely great that we have a working CI build again and it's being tested against PHP 8 now as well. And taking care of the deprecated fixture stuff.

Let me know if I've missed something.

Edit: Oh, I guess for running the tests against PHP 8+ it would have to be a version of Cake that supports it. 😅 Okay, just curious about my question about ^4.2 & >=7.2 then. Also, feel free to delete the TravisCI config file too.

@bcrowe
Copy link
Owner

bcrowe commented Jul 11, 2023

@ishanvyas22 @pabloelcolombiano I'll be checking this often so it doesn't get any further delayed. Let me know what you think.

@bcrowe
Copy link
Owner

bcrowe commented Jul 11, 2023

And let me know if you have Discord -- throwing me a message there anytime you make a PR in the future would get my eyes on things right away. Tons of notifications/emails and sometimes these slip by me for a little bit.

@ishanvyas22 ishanvyas22 force-pushed the cakephp44-upgrade branch 2 times, most recently from f6c16d2 to 33f6bc6 Compare July 12, 2023 05:12
@ishanvyas22 ishanvyas22 changed the title Upgrade CakePHP & PHP versions Bump CakePHP version to 4.2 Jul 12, 2023
@ishanvyas22
Copy link
Contributor Author

Hey @bcrowe, thanks for taking a look. I've changed min CakePHP requirements to ^4.2 and PHP at ^7.2.

@bcrowe
Copy link
Owner

bcrowe commented Jul 12, 2023

LGTM! Thanks for the edits and getting the CI build up and running. I'll release/tag this as a new major version 3.0.0.

@bcrowe bcrowe merged commit c6fd911 into bcrowe:master Jul 12, 2023
@bcrowe
Copy link
Owner

bcrowe commented Jul 12, 2023

https://github.com/bcrowe/cakephp-api-pagination/releases/tag/3.0.0

@ishanvyas22
Copy link
Contributor Author

Thanks @bcrowe 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants