-
Notifications
You must be signed in to change notification settings - Fork 13
Bump CakePHP version to 4.2 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bcrowe Can you please have a look at this? |
Hey, sorry for the delay! Let me take a look over this -- also I need to get the builds running again, not sure what happened there. Sit tight! Edit: Oh, I see you took care of the CI build... thank you! |
I think my only question is, should we instead use From what I see here: https://github.com/cakephp/cakephp/wiki#version-map |
Although, it's definitely great that we have a working CI build again and it's being tested against PHP 8 now as well. And taking care of the deprecated fixture stuff. Let me know if I've missed something. Edit: Oh, I guess for running the tests against PHP 8+ it would have to be a version of Cake that supports it. 😅 Okay, just curious about my question about |
@ishanvyas22 @pabloelcolombiano I'll be checking this often so it doesn't get any further delayed. Let me know what you think. |
And let me know if you have Discord -- throwing me a message there anytime you make a PR in the future would get my eyes on things right away. Tons of notifications/emails and sometimes these slip by me for a little bit. |
f6c16d2
to
33f6bc6
Compare
33f6bc6
to
f4e027e
Compare
Hey @bcrowe, thanks for taking a look. I've changed min CakePHP requirements to |
LGTM! Thanks for the edits and getting the CI build up and running. I'll release/tag this as a new major version |
Thanks @bcrowe 🙏🏼 |
Changelog
Fixed
Improved