Skip to content

Conversation

Devin345458
Copy link

@Devin345458 Devin345458 changed the title Update ApiPaginationComponent.php Cakephp 4.X changes Apr 6, 2020
@bcrowe
Copy link
Owner

bcrowe commented Jul 10, 2020

Covered in #4 unless you think this may be cleaner?

@bcrowe
Copy link
Owner

bcrowe commented Jul 10, 2020

@Devin345458 By the way, extremely sorry for the big delay. I've gotten #4 merged, and tagged with a 2.0.0 release. I've moved the CakePHP 3.x code into a 1.x branch. CakePHP 4.x code will live in master and be 2.x.x tags. Thanks for the help! And let me know if you think this PR is still relevant/an improvement on how #4 approached getting the attributes.

@Devin345458
Copy link
Author

@bcrowe No, I think the way you did it was fine. I will mention that they are getting rid of the [_serialize] array auto serialization soon according to the docs. It should be set via $this->viewBuilder()->setOption('serialize', ['recipe']); now. You can read about it here https://book.cakephp.org/4/en/appendices/4-0-migration-guide.html#view

@jfalbel
Copy link
Contributor

jfalbel commented Jan 14, 2021

@bcrowe can u please review @Devin345458 answer?

@bcrowe No, I think the way you did it was fine. I will mention that they are getting rid of the [_serialize] array auto serialization soon according to the docs. It should be set via $this->viewBuilder()->setOption('serialize', ['recipe']); now. You can read about it here https://book.cakephp.org/4/en/appendices/4-0-migration-guide.html#view

@bcrowe
Copy link
Owner

bcrowe commented Feb 10, 2021

Closed via #6

@bcrowe bcrowe closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants