fix animation and small padding when in landscape #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 Thanks for your PR！ |
xwenliang
added a commit
that referenced
this pull request
Feb 21, 2016
fix animation and small padding when in landscape
rodolphefauquez
pushed a commit
to Clintal/react-native-picker
that referenced
this pull request
Feb 16, 2018
modify consultation index screen Approved-by: Takahiro Ohata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more quick PR relating to #23. I just wanted to smooth out the width change transition a bit. With this new change the root level View doesn't actually resize even if you change the picker side. Instead, it only rotates (translates). It is always set to the largest side of the device. The buttons and the scroller slide left and right against the root View.
Why is this necessary? Well, this prevents a flash of partial width picker when you rotate from portrait to landscape lasting for one frame. It also makes sure that you don't have a few pixel padding on the right hand side.