Implement INT 13h Verify and fix CDROM MSF calculation#1
Implement INT 13h Verify and fix CDROM MSF calculation#1google-labs-jules[bot] wants to merge 2 commits into
Conversation
- Implemented INT 13h AH=04h (Verify Sectors) in `bios_disk.cpp`. The implementation reads sectors to verify readability without transferring data to the user buffer. - Fixed a TODO in `cdrom.c` for correct MSF (Minute, Second, Frame) subtraction logic, handling wrap-arounds correctly (75 frames/sec).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Implemented INT 13h AH=04h (Verify Sectors) in `bios_disk.cpp`: reads sectors to verify readability/CRC without transferring data. - Fixed CDROM MSF calculation in `cdrom.c`: correctly handles frame/second/minute underflow when decrementing. - Implemented CDROM seek range check in `cdrom.c`: prevents seeking past the disk capacity. - Implemented CDROM multi-block read loop in `cdrom.c`: allows reading multiple blocks as long as FIFO space permits.
This change implements the INT 13h AH=04h (Verify Sectors) function in the BIOS disk emulation, which was previously a stub. It also fixes a TODO in the CD-ROM emulation regarding MSF (Minute-Second-Frame) calculation, ensuring correct decrement logic across frame, second, and minute boundaries.
PR created automatically by Jules for task 9308703627414535795 started by @belikh