Skip to content
This repository was archived by the owner on Apr 17, 2018. It is now read-only.

Realnames #96

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Realnames #96

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed22f70
Merge branch 'master' of https://github.com/tricycle/lesswrong
LucasSloan Jul 9, 2013
3a61c26
Merge branch 'master' of https://github.com/tricycle/lesswrong
LucasSloan Jan 6, 2014
300ada3
Merge branch 'master' of https://github.com/tricycle/lesswrong
LucasSloan Apr 15, 2014
d3078f7
New feature - real names. Add a real name in preferences and user fa…
LucasSloan Apr 22, 2014
fec33b9
New feature - real names. Add a real name in preferences and user fa…
LucasSloan Apr 22, 2014
1a2f01c
Merge branch 'realnames' of https://github.com/PotatoDumplings/lesswr…
LucasSloan Apr 22, 2014
bdba277
Allow real names to use full Unicode character set.
LucasSloan May 6, 2014
2dff67e
Removed unnecessary Account commit.
Jul 26, 2014
e3dea7f
Move realname error checking into a multiple boolean, not multiple if…
LucasSloan Dec 22, 2014
30b9399
Clear the realname field to remove a realname.
LucasSloan Jan 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move realname error checking into a multiple boolean, not multiple if… 
… expression.

Indicate that a real name is optional on the preferences screen.
  • Loading branch information
@LucasSloan
LucasSloan committed Dec 22, 2014
commit e3dea7f3e6477a4ad8249bd1cec3537ed4f9a6f1
6 changes: 1 addition & 5 deletions r2/r2/controllers/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,12 +588,8 @@ def POST_update(self, res, email, curpass, realname, password, newpass, verpass)
res._update('curpass', value='')
return

if res._chk_error(errors.BAD_REALNAME_CHARS):
if res._chk_error(errors.BAD_REALNAME_CHARS) or res._chk_error(errors.BAD_REALNAME_SHORT) or res._chk_error(errors.BAD_REALNAME_LONG):
res._focus('real_name')
elif res._chk_error(errors.BAD_REALNAME_SHORT):
res._focus('real_name')
elif res._chk_error(errors.BAD_REALNAME_LONG):
res._focus('real_name')
if realname and realname == c.user.real_name:
Copy link
Contributor

@jack-trikeapps jack-trikeapps Dec 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong to me. I think you should remove minimum length limits on real names and make it so that an empty string is interpreted as a request to delete.

Copy link
Contributor Author

@LucasSloan LucasSloan Dec 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried that but it doesn't really work in this case - the update password/email/realname form handles 3 different actions - entering nothing should result in nothing happening. I suspect that people will want to remove their real name rarely enough to make the bizarre syntax acceptable, unless you have a better suggestion?

Copy link
Contributor

@jack-trikeapps jack-trikeapps Dec 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best way to deal with this is to pre-fill the form with the user's current realname, and if they blank it out then delete it from their profile. If it's unchanged then we can infer that the form is being used for something else (password change etc.).

c.user.real_name = None
c.user._commit()
Expand Down
10 changes: 5 additions & 5 deletions r2/r2/templates/prefupdate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@
## software over a computer network and provide for limited attribution for the
## Original Developer. In addition, Exhibit A has been modified to be consistent
## with Exhibit B.
##
##
## Software distributed under the License is distributed on an "AS IS" basis,
## WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License for
## the specific language governing rights and limitations under the License.
##
##
## The Original Code is Reddit.
##
##
## The Original Developer is the Initial Developer. The Initial Developer of
## the Original Code is CondeNet, Inc.
##
##
## All portions of the code written by CondeNet are Copyright (c) 2006-2008
## CondeNet, Inc. All Rights Reserved.
################################################################################
Expand All @@ -39,7 +39,7 @@
</td>
</tr>
<tr>
<td align="right">${_("Real Name")}:</td>
<td align="right">${_("Real Name (optional)")}:</td>
<td><input name="real_name" type="text" value="${hasattr(c.user,'real_name') and c.user.real_name or ''}" title="Enter your current real name to remove it"/></td>
<td>
${error_field("BAD_REALNAME_CHARS")}
Expand Down
2 changes: 1 addition & 1 deletion tasks/manual_test_script
Open in desktop
Submodule manual_test_script updated from a49ad9 to c2d154