Skip to content

Impl FeatureFlagsWebpackPlugin #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Impl FeatureFlagsWebpackPlugin #592

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a8a8ac2
chore: init package
yarastqt Dec 19, 2020
4d3782a
chore: add @types/webpack deps
yarastqt Dec 19, 2020
7004caa
feat: impl FeatureFlagsWebpackPlugin
yarastqt Dec 19, 2020
abe3f6d
chore: prepare pgk for publish
yarastqt Dec 19, 2020
74e2aae
build: include only src dir for ts
yarastqt Dec 19, 2020
e1095d3
chore: fix eslint no-use-before-define
yarastqt Dec 20, 2020
5d423df
refactor: separate cb hell to fns
yarastqt Dec 20, 2020
1f52a1f
chore: infra for units
yarastqt Dec 20, 2020
0529bf4
chore: use type-cast for required options
yarastqt Dec 20, 2020
b93101b
chore: setup jest config for js files
yarastqt Dec 20, 2020
a353f06
test: add units for FeatureFlagsWebpackPlugin
yarastqt Dec 20, 2020
d5d1fc6
fix: fix setting default options
yarastqt Dec 20, 2020
80453eb
test: add unit for isFeatureEnabledFnName case
yarastqt Dec 20, 2020
5f11a1d
chore: fix ts issue for any type
yarastqt Dec 20, 2020
bed3b99
wip
yarastqt Dec 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix setting default options
  • Loading branch information
@yarastqt
yarastqt committed Dec 20, 2020
commit d5d1fc67494ed1e077c0751372cadf3134f5d1b6
2 changes: 1 addition & 1 deletion packages/feature-flags-webpack-plugin/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type PluginOptions = {

class FeatureFlagsWebpackPlugin {
constructor(public options: PluginOptions) {
Object.assign(this.options, { isFeatureEnabledFnName: 'isFeatureEnabled' })
this.options = Object.assign({ isFeatureEnabledFnName: 'isFeatureEnabled' }, this.options)
}

apply(compiler: Compiler) {
Expand Down