Skip to content
This repository was archived by the owner on Feb 27, 2018. It is now read-only.

add babel-preset-es2015 #36

Merged
merged 2 commits into from
Nov 27, 2017
Merged

add babel-preset-es2015 #36

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1779113
add babel-preset-es2015
Lakate Nov 17, 2017
f8b081c
return polyfills in prod config
Lakate Nov 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/bem-react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"babel-loader": "7.0.0",
"babel-plugin-bem-import": "1.3.2",
"@babel/preset-env": "^7.0.0-beta.4",
"babel-preset-es2015": "^6.24.1",
Copy link

@Vittly Vittly Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also return this

Copy link
Member

@awinogradov awinogradov Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need two presets with the same functionality?

Copy link
Author

@Lakate Lakate Nov 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it is used to config https://github.com/bem/create-bem-react-app/blob/master/packages/bem-react-scripts/config/webpack.config.dev.js#L152

Copy link
Member

@awinogradov awinogradov Nov 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok) We need only one ;)

Copy link
Member

@awinogradov awinogradov Nov 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove @babel/preset-env

Copy link
Author

@Lakate Lakate Nov 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :)

"babel-preset-react-app": "^2.1.1",
"babel-runtime": "^6.20.0",
"@bem/sdk.config": "0.0.4",
Expand Down