Skip to content

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jan 13, 2023
@haslinghuis haslinghuis self-assigned this Jan 13, 2023
@haslinghuis
Copy link
Member Author

image

@github-actions

This comment has been minimized.

@McGiverGim
Copy link
Member

Now it works as expected, it fits nicely... Buy is almost impossible to use it in HD mode 😉
Here and example with one element only... Where is it? 😋

Screenshot_20230113-194502

@blckmn
Copy link
Member

blckmn commented Jan 13, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member Author

@McGiverGim any suggestions? As this tab should really switch to portrait mode.

@McGiverGim
Copy link
Member

It's prettier with this PR, but more useful being bigger and scrolling.
Maybe we can add a button to make it bigger or not only for Android? Something like a zoom button.

@github-actions

This comment has been minimized.

@haslinghuis
Copy link
Member Author

@McGiverGim please check now 😋

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.2% 12.2% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@McGiverGim
Copy link
Member

Good idea, but:

  • Strange to see the button in the toolbar.
  • the vertical space between the top bar and the bottom is ridiculous ☹️
    Screenshot_20230115-081833

@McGiverGim
Copy link
Member

McGiverGim commented Jan 15, 2023

I think a simple button, maybe just next to the font combo, to modify the css and change the rule changed in this PR to the old one and viceversa?
Edit: better a checkbox than a button.

@blckmn blckmn merged commit 4b0d446 into betaflight:master Jan 15, 2023
@haslinghuis haslinghuis deleted the fix-osd-hd-android branch January 15, 2023 23:53
@haslinghuis
Copy link
Member Author

@McGiverGim now it's merged have to start a new PR. Have to do more research.

@McGiverGim
Copy link
Member

I don't understand why merge this. We add a button in the RC4 that the most probably is that we remove one version later.

We will not find any "perfect" solution, because the screen is small and the OSD preview is not, but we must let something "usable". If we want to give a preview that fits in the screen as default, it's ok to me, but we must let a bigger option to ubicate the components.

I will try to do the change of adding a checkbox myself and will open a new PR to test how it works... ;)

McGiverGim added a commit to McGiverGim/betaflight-configurator that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants