-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix OSD (HD) display overflow on Android #3241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
@McGiverGim any suggestions? As this tab should really switch to portrait mode. |
It's prettier with this PR, but more useful being bigger and scrolling. |
7b2bb0c
to
5b83d33
Compare
This comment has been minimized.
This comment has been minimized.
@McGiverGim please check now 😋 |
5b83d33
to
db4f778
Compare
SonarCloud Quality Gate failed.
|
Do you want to test this code? Here you have an automated build: |
I think a simple button, maybe just next to the font combo, to modify the css and change the rule changed in this PR to the old one and viceversa? |
@McGiverGim now it's merged have to start a new PR. Have to do more research. |
I don't understand why merge this. We add a button in the RC4 that the most probably is that we remove one version later. We will not find any "perfect" solution, because the screen is small and the OSD preview is not, but we must let something "usable". If we want to give a preview that fits in the screen as default, it's ok to me, but we must let a bigger option to ubicate the components. I will try to do the change of adding a checkbox myself and will open a new PR to test how it works... ;) |
This reverts commit 4b0d446.
No description provided.