Finished issue #6 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfwg
approved these changes
Jun 27, 2017
| // let fixture = TestBed.createComponent(AppComponent); | ||
| // const app = fixture.debugElement.componentInstance; | ||
| // expect(app.title).toEqual('app works!'); | ||
| // })); |
There was a problem hiding this comment.
Is there a reason we keep those comment?
There was a problem hiding this comment.
Actually we can delete it. I forgot to clean that up..
There was a problem hiding this comment.
No worries, let's clean it in later iterations .
|
Nice work, LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6 done, also I change the all other route to the path /404 and make the behavior is same.
ng testnow is passed and also forng e2e, but I don't think I have a good test coverage... If someone else who wants to help can try to add more test on it.