Skip to content

Detailed global enable #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Detailed global enable #141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
45603ff
Split global enable/disable into additions, changes, and deletions en…
aswanson08 Feb 10, 2017
3572c02
Fixed soft deletions not being handled
aswanson08 Feb 10, 2017
e37fd8f
Updated/added unit tests
aswanson08 Feb 10, 2017
d79e167
Updated how additions are handled to improve performance
aswanson08 Feb 10, 2017
204725d
Renamed objects/variables related to modifications and added back old…
aswanson08 Feb 10, 2017
be07aa4
Changed as much code as possible back to its original syntax
aswanson08 Feb 10, 2017
5471b3b
Added an AuditModifications method and restored the original AuditCha…
aswanson08 Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed as much code as possible back to its original syntax
  • Loading branch information
@aswanson08
aswanson08 committed Feb 10, 2017
commit be07aa4fbd21637ce729aeefe45d208d87fb79e9
4 changes: 1 addition & 3 deletions TrackerEnabledDbContext.Common.Testing/PersistanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ namespace TrackerEnabledDbContext.Common.Testing
public virtual void Initialize()
{
_transaction = Db.Database.BeginTransaction();
GlobalTrackingConfig.AdditionsEnabled = true;
GlobalTrackingConfig.ModificationsEnabled = true;
GlobalTrackingConfig.DeletionsEnabled = true;
GlobalTrackingConfig.Enabled = true;
GlobalTrackingConfig.TrackEmptyPropertiesOnAdditionAndDeletion = false;
GlobalTrackingConfig.DisconnectedContext = false;
GlobalTrackingConfig.ClearFluentConfiguration();
Expand Down
2 changes: 1 addition & 1 deletion TrackerEnabledDbContext.Common/Configuration/GlobalTrackingConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace TrackerEnabledDbContext.Common.Configuration
{
public static class GlobalTrackingConfig
{
public static bool ChangesEnabled
public static bool Enabled
{
get { return AdditionsEnabled || ModificationsEnabled || DeletionsEnabled; }
set
Expand Down
1 change: 1 addition & 0 deletions TrackerEnabledDbContext.Common/Interfaces/ITrackerContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public interface ITrackerContext : IDbContext
{
DbSet<AuditLog> AuditLog { get; set; }
DbSet<AuditLogDetail> LogDetails { get; set; }
bool TrackingEnabled { get; set; }
bool AdditionTrackingEnabled { get; set; }
bool ModificationTrackingEnabled { get; set; }
bool DeletionTrackingEnabled { get; set; }
Expand Down
4 changes: 1 addition & 3 deletions TrackerEnabledDbContext.Identity.IntegrationTests/FluentConfigurationTestsForIdentity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ public class FluentConfigurationTestsForIdentity : PersistanceTests<TestTrackerI
[TestMethod]
public void Can_recognise_global_tracking_indicator_when_disabled()
{
GlobalTrackingConfig.AdditionsEnabled = false;
GlobalTrackingConfig.ModificationsEnabled = false;
GlobalTrackingConfig.DeletionsEnabled = false;
GlobalTrackingConfig.Enabled = false;
EntityTracker
.TrackAllProperties<POCO>();

Expand Down
4 changes: 1 addition & 3 deletions TrackerEnabledDbContext.Identity.IntegrationTests/TrackerIdentityContextIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,9 +423,7 @@ public void Can_recognise_context_tracking_indicator_when_disabled()
NormalModel model = ObjectFactory.Create<NormalModel>();
Db.NormalModels.Add(model);

Db.AdditionTrackingEnabled = false;
Db.DeletionTrackingEnabled = false;
Db.ModificationTrackingEnabled = false;
Db.TrackingEnabled = false;
Db.SaveChanges();

model.AssertNoLogs(Db, model.Id);
Expand Down
2 changes: 1 addition & 1 deletion TrackerEnabledDbContext.Identity/TrackerIdentityContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public bool TrackingEnabled
{
get
{
return GlobalTrackingConfig.ChangesEnabled && (_additionTrackingEnabled ||
return GlobalTrackingConfig.Enabled && (_additionTrackingEnabled ||
_modificationTrackingEnabled ||
_deletionTrackingEnabled);
}
Expand Down
4 changes: 1 addition & 3 deletions TrackerEnabledDbContext.IntegrationTests/TrackerContextIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,9 +572,7 @@ public void Can_recognise_context_tracking_indicator_when_disabled()
NormalModel model = ObjectFactory.Create<NormalModel>();
Db.NormalModels.Add(model);

Db.AdditionTrackingEnabled = false;
Db.ModificationTrackingEnabled = false;
Db.DeletionTrackingEnabled = false;
Db.TrackingEnabled = false;
Db.SaveChanges();

model.AssertNoLogs(Db, model.Id);
Expand Down
2 changes: 1 addition & 1 deletion TrackerEnabledDbContext/TrackerContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public bool TrackingEnabled
{
get
{
return GlobalTrackingConfig.ChangesEnabled && (_additionTrackingEnabled ||
return GlobalTrackingConfig.Enabled && (_additionTrackingEnabled ||
_modificationTrackingEnabled ||
_deletionTrackingEnabled);
}
Expand Down