add scripts and default task so JS is correctly bundled#5
Closed
jancborchardt wants to merge 1 commit intobillgathen:masterfrom
Closed
add scripts and default task so JS is correctly bundled#5jancborchardt wants to merge 1 commit intobillgathen:masterfrom
jancborchardt wants to merge 1 commit intobillgathen:masterfrom
Conversation
billgathen
added a commit
that referenced
this pull request
Nov 24, 2015
Owner
|
After doing the keycodes merge, this one would have looked messier if automatically merged, so I cloned the code and did a manual push (referencing this PR). Should be good! Thanks again for your contributions. 😄 |
Contributor
Author
|
@billgathen sure, no worries. :) There’s also |
Owner
|
I haven't used that one before. I'll check it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no default task set, so simply running
gulpwasn’t possible. Also, gulp watch only bundled the JS when it was changed on runtime it seems.@billgathen please review. I know you put the compiled code in the repo, but I didn’t compile (also for the other pull request) just to be able to see the changes better.