Skip to content

Simplification Changes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Darkace01 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Simplification Changes #1

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19c67cf
Simplified the DTOs
Darkace01 Oct 25, 2020
77c906e
Simplified Code and Repository
Darkace01 Oct 25, 2020
7d6821f
Simplified IF Statements
Darkace01 Oct 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplified IF Statements
  • Loading branch information
@Darkace01
Darkace01 committed Oct 25, 2020
commit 7d6821fd0492b4f1eec8d4054c2e640716289f07
11 changes: 0 additions & 11 deletions Controllers/CommandsController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ public ActionResult<CommandReadDto> GetCommandById(int id)
{
var commandItem = _repository.GetCommandById(id);
if (commandItem != null)
{
return Ok(_mapper.Map<CommandReadDto>(commandItem));
}
return NotFound();
}

Expand All @@ -62,9 +60,7 @@ public ActionResult UpdateCommand(int id, CommandUpdateDto commandUpdateDto)
{
var commandModelFromRepo = _repository.GetCommandById(id);
if (commandModelFromRepo == null)
{
return NotFound();
}
_mapper.Map(commandUpdateDto, commandModelFromRepo);

_repository.UpdateCommand(commandModelFromRepo);
Expand All @@ -77,17 +73,12 @@ public ActionResult PartialCommandUpdate(int id, JsonPatchDocument<CommandUpdate
{
var commandModelFromRepo = _repository.GetCommandById(id);
if (commandModelFromRepo == null)
{
return NotFound();
}

var commandToPatch = _mapper.Map<CommandUpdateDto>(commandModelFromRepo);
patchDoc.ApplyTo(commandToPatch, ModelState);

if (!TryValidateModel(commandToPatch))
{
return ValidationProblem(ModelState);
}

_mapper.Map(commandToPatch, commandModelFromRepo);

Expand All @@ -102,9 +93,7 @@ public ActionResult DeleteCommand(int id)
{
var commandModelFromRepo = _repository.GetCommandById(id);
if (commandModelFromRepo == null)
{
return NotFound();
}
_repository.DeleteCommand(commandModelFromRepo);

return NoContent();
Expand Down