-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(lint/useIterableCallbackReturn): add allowImplicit option #9489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mvanhorn
wants to merge
10
commits into
biomejs:next
from
mvanhorn:osc/9445-allow-implicit-callback-return
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dde21d6
feat(lint/useIterableCallbackReturn): add allowImplicit option
mvanhorn 78b550c
chore: add changeset for #9445
mvanhorn e89b399
chore: bump changeset from patch to minor
mvanhorn 455711e
fix(lint): detect fall-through paths with mixed returns in allowImpli…
mvanhorn a742f34
Address review feedback: separate tests, .filter(Boolean) example
mvanhorn 629f724
Address review: remove implied doc line, fix valid test header format
mvanhorn fa7c864
fix(test): add missing diagnostics header to allowImplicitInvalid.js
mvanhorn 3085183
Merge branch 'next' into osc/9445-allow-implicit-callback-return
ematipico f9327c2
[autofix.ci] apply automated fixes
autofix-ci[bot] 6c22bb1
Merge branch 'next' into osc/9445-allow-implicit-callback-return
dyc3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(test): add missing diagnostics header to allowImplicitInvalid.js
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Loading branch information
commit fa7c8642f71fa4acf39908253c63fa23d5da0fca
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
...biome_js_analyze/tests/specs/suspicious/useIterableCallbackReturn/allowImplicitInvalid.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid files must have
// should not generate diagnostics. You're using an AI agent, load the skills we provide.This comment was marked as low quality.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sorry, between the two files I got confused, but it's easily understandable:
Every file should have the top-level comments
This comment was marked as low quality.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.