Skip to content

Save/restore TransactionView and recentRequestsView tables column sizes #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 22, 2021
Merged

Save/restore TransactionView and recentRequestsView tables column sizes #205

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3913d1e
qt: Drop buggy TableViewLastColumnResizingFixer class
hebasto Jan 31, 2021
ecdbaf7
qt, refactor: Drop intermediate assignment
hebasto Jan 31, 2021
788205c
qt: Move transactionView properties settings to constructor
hebasto Jan 31, 2021
9c5f4f2
qt: Save/restore TransactionView table column sizes
hebasto Jan 31, 2021
f5c8093
qt: Move recentRequestsView properties settings to constructor
hebasto Jan 31, 2021
964885d
qt: Save/restore recentRequestsView table column sizes
hebasto Jan 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
qt, refactor: Drop intermediate assignment 
This change improves code readability.
  • Loading branch information
@hebasto
hebasto committed Jan 31, 2021
commit ecdbaf71c0e1a4363e7eb019dabeb0018522ef70
24 changes: 10 additions & 14 deletions src/qt/transactionview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,27 +126,23 @@ TransactionView::TransactionView(const PlatformStyle *platformStyle, QWidget *pa
vlayout->setContentsMargins(0,0,0,0);
vlayout->setSpacing(0);

QTableView *view = new QTableView(this);
transactionView = new QTableView(this);
transactionView->setObjectName("transactionView");
vlayout->addLayout(hlayout);
vlayout->addWidget(createDateRangeWidget());
vlayout->addWidget(view);
vlayout->addWidget(transactionView);
vlayout->setSpacing(0);
int width = view->verticalScrollBar()->sizeHint().width();
int width = transactionView->verticalScrollBar()->sizeHint().width();
// Cover scroll bar width with spacing
if (platformStyle->getUseExtraSpacing()) {
hlayout->addSpacing(width+2);
} else {
hlayout->addSpacing(width);
}
// Always show scroll bar
view->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOn);
view->setTabKeyNavigation(false);
view->setContextMenuPolicy(Qt::CustomContextMenu);

view->installEventFilter(this);

transactionView = view;
transactionView->setObjectName("transactionView");
transactionView->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOn);
transactionView->setTabKeyNavigation(false);
transactionView->setContextMenuPolicy(Qt::CustomContextMenu);
transactionView->installEventFilter(this);

// Actions
abandonAction = new QAction(tr("Abandon transaction"), this);
Expand Down Expand Up @@ -183,8 +179,8 @@ TransactionView::TransactionView(const PlatformStyle *platformStyle, QWidget *pa
connect(search_widget, &QLineEdit::textChanged, prefix_typing_delay, static_cast<void (QTimer::*)()>(&QTimer::start));
connect(prefix_typing_delay, &QTimer::timeout, this, &TransactionView::changedSearch);

connect(view, &QTableView::doubleClicked, this, &TransactionView::doubleClicked);
connect(view, &QTableView::customContextMenuRequested, this, &TransactionView::contextualMenu);
connect(transactionView, &QTableView::doubleClicked, this, &TransactionView::doubleClicked);
connect(transactionView, &QTableView::customContextMenuRequested, this, &TransactionView::contextualMenu);

connect(bumpFeeAction, &QAction::triggered, this, &TransactionView::bumpFee);
connect(abandonAction, &QAction::triggered, this, &TransactionView::abandonTx);
Expand Down