Skip to content

Refactor TransactionDesc::FormatTxStatus and TransactionStatus #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Refactor TransactionDesc::FormatTxStatus and TransactionStatus #552

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b1bc143
qt, refactor: remove redundant scope in `TransactionDesc::FormatTxSta…
w0xlt Feb 18, 2022
045f8d0
scripted-diff: rename nDepth -> depth
w0xlt Feb 21, 2022
ad6aded
qt, refactor: remove unused parameters in `TransactionDesc::FormatTxS…
w0xlt Feb 21, 2022
66d58ad
qt, refactor: remove unused field `qint64 TransactionStatus::open_for`
w0xlt Feb 21, 2022
343f83d
qt, refactor: Use member initializers in TransactionStatus
w0xlt Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
qt, refactor: remove unused parameters in `TransactionDesc::FormatTxS… 
…tatus()`
  • Loading branch information
@w0xlt
w0xlt committed Feb 24, 2022
commit ad6adedb46e25870bcdabeca93c51c3ac2a33de7
4 changes: 2 additions & 2 deletions src/qt/transactiondesc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ using wallet::ISMINE_SPENDABLE;
using wallet::ISMINE_WATCH_ONLY;
using wallet::isminetype;

QString TransactionDesc::FormatTxStatus(const interfaces::WalletTx& wtx, const interfaces::WalletTxStatus& status, bool inMempool, int numBlocks)
QString TransactionDesc::FormatTxStatus(const interfaces::WalletTxStatus& status, bool inMempool)
{
int depth = status.depth_in_main_chain;
if (depth < 0) {
Expand Down Expand Up @@ -93,7 +93,7 @@ QString TransactionDesc::toHTML(interfaces::Node& node, interfaces::Wallet& wall
CAmount nDebit = wtx.debit;
CAmount nNet = nCredit - nDebit;

strHTML += "<b>" + tr("Status") + ":</b> " + FormatTxStatus(wtx, status, inMempool, numBlocks);
strHTML += "<b>" + tr("Status") + ":</b> " + FormatTxStatus(status, inMempool);
strHTML += "<br>";

strHTML += "<b>" + tr("Date") + ":</b> " + (nTime ? GUIUtil::dateTimeStr(nTime) : "") + "<br>";
Expand Down
2 changes: 1 addition & 1 deletion src/qt/transactiondesc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class TransactionDesc: public QObject
private:
TransactionDesc() {}

static QString FormatTxStatus(const interfaces::WalletTx& wtx, const interfaces::WalletTxStatus& status, bool inMempool, int numBlocks);
static QString FormatTxStatus(const interfaces::WalletTxStatus& status, bool inMempool);
};

#endif // BITCOIN_QT_TRANSACTIONDESC_H