Add median-time-past (MTP) calculation to CheckPoint #2037
Conversation
Add MTP calculation methods for CheckPoint following Bitcoin's BIP113: - `median_time_past()`: calculates MTP for current block using previous 11 blocks - `next_median_time_past()`: calculates MTP for next block using current + previous 10 blocks - Returns None when timestamps unavailable or required blocks missing Includes comprehensive tests for all edge cases. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
evanlinjin
force-pushed
the
feature/mtp
branch
from
f97553f to
0f75c22
Compare
evanlinjin
requested review from
ValuedMammal,
LagginTimes and
oleonardolima
There was a problem hiding this comment.
cACK 0f75c22
I'll just give it a try with some other test scenarios before final ACK.
evanlinjin
force-pushed
the
feature/mtp
branch
2 times, most recently
from
f97553f to
46e751f
Compare
| pub fn median_time_past(&self) -> Option<u32> { | ||
| let current_height = self.height(); | ||
| let earliest_height = current_height.saturating_sub(Self::MTP_BLOCK_COUNT); | ||
| self._median_time_past(earliest_height..current_height) | ||
| } |
There was a problem hiding this comment.
I'm curious if these new APIs could output wrong/invalid values if the blocks inserted have a wrong/invalid time field e.g malicious block source.
There was a problem hiding this comment.
Definitely. We are trusting the chain source here (and everywhere in BDK). Eventually, we should think about how to verify all consensus rules in BDK: difficulty, PoW, MTP, etc.
evanlinjin
force-pushed
the
feature/mtp
branch
from
46e751f to
74d30d8
Compare
There was a problem hiding this comment.
cACK 74d30d8
I didn't really find other test vectors that we could use.
Another thing that should probably be handled in a future PR is updating the calculation of Balance for the immature category, we probably should update it to consider transactions that are not yet mature considering the Locktime and MTP for it.
Description
This PR adds the ability to calculate median-time-past (MTP) for
CheckPointstructures, implementing the functionality described in #2036.MTP is a critical component of Bitcoin's consensus rules (BIP113) used for time-based transaction validations. It provides a more robust timestamp by using the pseudo-median of up to 11 previous block timestamps.
Notes to the reviewers
The MTP calculation needs double checking.
CheckPoint::median_time_pastcalculates the MTP value by looking at the 11 blocks that are BEFORE the current. If we call.median_time_paston the tip, is this the right value to compare against timelocked transactions going into the mempool?Changelog notice
Added
block_time()method toToBlockHashtrait to optionally return block timestampsmedian_time_past()andnext_median_time_past()methods toCheckPointfor calculating MTP according to BIP113Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Fixes #2036
🤖 Generated with Claude Code