Skip to content

chore(msrv): bump MSRV to 1.85.0 #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(msrv): bump MSRV to 1.85.0 #2055

wants to merge 2 commits into from

Conversation

oleonardolima
Copy link
Contributor

@oleonardolima oleonardolima commented Oct 2, 2025 •
edited
Loading

fixes #2009

Description

It bumps the project MSRV to 1.85.0, as the latest Debian trixie release establishes that as stable, see: https://tracker.debian.org/pkg/rustc.

This PR does:

  • update all references to the previous 1.63.0 MSRV.
  • update the rust-version to 1.85.0.
  • update the CI to not exclude bdk_electrum anymore.
  • update the ci/pin-msrv.sh to 1.85.0.

Notes to the reviewers

Should we update something in the GitHub repository configuration to get rid of old mandatory CI jobs ?

Changelog notice

### Changed

- Update all references to the previous 1.63.0 MSRV.
- Update the rust-version to 1.85.0.
- Update the CI to not exclude `bdk_electrum` anymore.
- Update the ci/pin-msrv.sh to 1.85.0.

Checklists

All Submissions:

@oleonardolima
chore(msrv): bump MSRV to 1.85.0
e4d94c7 
- update all references to previous 1.63.0 MSRV.
- update the rust-version to 1.85.0.
- update the CI to not exclude bdk_electrum anymore.
- update the ci/pin-msrv.sh to 1.85.0.
@oleonardolima
fix(clippy): use is_none_or instead of map_or
b6e75cb
@oleonardolima oleonardolima force-pushed the chore/bump-msrv-to-1.85.0 branch from b04bbed to b6e75cb Compare October 2, 2025 04:53
@oleonardolima oleonardolima marked this pull request as ready for review October 2, 2025 05:14
@oleonardolima oleonardolima self-assigned this Oct 2, 2025
@oleonardolima oleonardolima added chore Non-coding related work github_actions Pull requests that update GitHub Actions code labels Oct 2, 2025
@oleonardolima oleonardolima moved this to Needs Review in BDK Chain Oct 2, 2025
evanlinjin
evanlinjin approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b6e75cb

Ran cargo test --all-features with:

❯ cargo --version
cargo 1.85.0 (d73d2caf9 2024-12-31)

@evanlinjin evanlinjin mentioned this pull request Oct 2, 2025
Closed
2 tasks
@oleonardolima oleonardolima mentioned this pull request Oct 2, 2025
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

@notmandatory notmandatory Awaiting requested review from notmandatory

Assignees

@oleonardolima oleonardolima

Labels
chore Non-coding related work github_actions Pull requests that update GitHub Actions code
Projects
BDK Chain
Status: Needs Review
Milestone
Chain 0.24.0
Development

Successfully merging this pull request may close these issues.

Update MSRV to 1.85
2 participants
@oleonardolima @evanlinjin