Skip to content

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Mar 14, 2023

  • Fix build-test workflow cache step
  • Pin de-dependency versions for zip and base64ct to work with MSRV 1.57
  • Add feature gates in doc tests
  • Fix rust 1.65.0 clippy warning derive-partial-eq-without-eq
  • Include required async in async-https feature

@notmandatory notmandatory self-assigned this Mar 14, 2023
@coveralls
Copy link

coveralls commented Mar 14, 2023

Pull Request Test Coverage Report for Build 4418139500

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.173%

Totals Coverage Status
Change from base Build 4415563573: 0.1%
Covered Lines: 833
Relevant Lines: 1039

💛 - Coveralls

@notmandatory notmandatory added this to the Release 0.4.0 milestone Mar 14, 2023
Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e634904

@vladimirfomene vladimirfomene merged commit 3496410 into bitcoindevkit:master Mar 14, 2023
@coveralls
Copy link

coveralls commented Oct 2, 2024

Pull Request Test Coverage Report for Build 4417691513

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.173%

Totals Coverage Status
Change from base Build 4415563573: 0.1%
Covered Lines: 833
Relevant Lines: 1039

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants