Skip to content

Conversation

MaxFangX
Copy link
Contributor

See the server-side handler - unlike the other tx endpoints, this one doesn't first check if the tx is known.

Also added a test that confirms this behavior.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! LGTM I think.

@vladimirfomene vladimirfomene added the bug Something isn't working label Apr 26, 2023
Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ACK

@vladimirfomene vladimirfomene merged commit c3b72ec into bitcoindevkit:master Apr 28, 2023
@MaxFangX MaxFangX deleted the tx-status-no-opt branch April 28, 2023 17:20
@notmandatory notmandatory added this to the Release 0.5.0 milestone May 9, 2023
oleonardolima added a commit to oleonardolima/fedimint that referenced this pull request May 24, 2023
- fix: it needed to update where `get_tx_status` was being used, as it
  used to return an `Option<TxStatus>`, but now returns a `TxStatus`,
  please refer to: bitcoindevkit/rust-esplora-client#46 (comment)

fixes fedimint#2325
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4793145247

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 15 (93.33%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 80.558%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/blocking.rs 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/blocking.rs 1 61.81%
src/async.rs 2 82.11%
Totals Coverage Status
Change from base Build 4772067577: 0.3%
Covered Lines: 837
Relevant Lines: 1039

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4793145247

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 15 (93.33%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 80.558%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/blocking.rs 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/blocking.rs 1 61.81%
src/async.rs 2 82.11%
Totals Coverage Status
Change from base Build 4772067577: 0.3%
Covered Lines: 837
Relevant Lines: 1039

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants