Skip to content

Refactor: Separate interface from HWI calls and add HWI binary support #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Refactor: Separate interface from HWI calls and add HWI binary support #105

wants to merge 9 commits into from

Conversation

ben-kaufman
Copy link

@ben-kaufman ben-kaufman commented Aug 29, 2024 •
edited
Loading

Changes

  • Separated the interface from the Python dependent implementation
  • Created a new module structure to support multiple implementations for making HWI calls
  • Added a binary implementation alongside the existing Python implementation allowing to interact with HWI using a binary file

Benefits

  • Increased modularity and flexibility
  • Allows for easy addition of new implementations in the future
  • Maintains compatibility with existing Python implementation while introducing binary support

Fix #92 by allowing to use rust-hwi with a binary file that can be easily packaged inside a consumer directed desktop app.

@ben-kaufman ben-kaufman force-pushed the separate-python branch 3 times, most recently from e1a5bcc to 6a9c40c Compare August 29, 2024 05:34
@notmandatory notmandatory added the new feature New feature or request label Aug 29, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Aug 29, 2024
@ben-kaufman ben-kaufman force-pushed the separate-python branch 2 times, most recently from fe20da9 to fccbed0 Compare August 30, 2024 18:58
@notmandatory notmandatory removed this from the 1.0.0-beta milestone Sep 19, 2024
@notmandatory notmandatory mentioned this pull request Sep 23, 2024
Open
@ben-kaufman
Copy link
Author

@notmandatory I've fixed the issue from the merge of the Signer. The PR should be ready for review.

@notmandatory
Copy link
Member

@ben-kaufman sorry for the delay in reviewing this. I've been focused on the bdk 1.0 work. Will test this out as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ben-kaufman ben-kaufman

Labels
new feature New feature or request
Projects
BDK Wallet
Status: Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove need for Python dep manual installation
2 participants
@ben-kaufman @notmandatory