-
Notifications
You must be signed in to change notification settings - Fork 142
Newsletter-111: translate into Chinese #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsletter-111: translate into Chinese #2001
Conversation
This reverts commit bd12d14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now a conflicting PR because of the changes required in the last newsletter recently merged. I suspect all of the other open PRs are conflicting for the same reason.
@bittomhan perhaps you can just include the files for each newsletter's PR and not the other newsletter files? Although there would be broken links for the newsletter that have not been merged yet.
Or perhaps we just have one open zh translation PR at a time? Or someone else has a suggestion.
I double checked this is one PR issue which affact all other PR. I have already checked and fixed it. I will keep the zh translation PR in 5 newsletters. Thank you for your help! |
4ac78a6
to
8432b50
Compare
@bittomhan I used this approach to squash all the commits from this branch into one and also dropped the commit to change 110: https://stackoverflow.com/a/14885097 |
Thank you and I used the command on local pc. It can be used to check the diff and I have already see that even I commit it there will be no change on the PR. So I know that it is OK. Thank you! |
Yes, but the idea is to have only commits related to the newsletter in the PR for: 1. simplicity and 2. not having to rebase if an earlier newsletter changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
No description provided.