Skip to content

Conversation

@harding
Copy link
Collaborator

@harding harding commented Mar 16, 2020

Another short one this week.

Copy link
Member

@adamjonas adamjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small nit. Looks good otherwise.

- [Bitcoin Core #16902][] changes consensus code to fix an inefficiency
in the parsing of `OP_IF` and related opcodes. In legacy and segwit
v0 script, the inefficiency isn't believed to cause any significant
problems, but the proposal for [tapscript][topic tapscript] would
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is a couple of ideas. Suggest breaking it up.

Suggested change
problems, but the proposal for [tapscript][topic tapscript] would
problems. Still, the proposal for [tapscript][topic tapscript] would

@jnewbery jnewbery added the newsletters Publishing/translating/editing newsletters label Mar 16, 2020
@dongcarl
Copy link
Contributor

An attempt:

LND #3821 adds anchor commitments for LN channels and enables it by default if both participating nodes of a channel signal support. Anchor commitment transactions can be fee bumped unilaterally by either party, which is useful because commitment transactions might be broadcast a long time after they commit to their on-chain feerate. See the "Anchor outputs" topic for more details.

@harding
Copy link
Collaborator Author

harding commented Mar 17, 2020

@dongcarl LGTM, thanks! Added to the newsletter as written except that I removed the last sentence and placed its link in the first sentence (without otherwise editing that sentence).

Also ACK @bitschmidty's section. Thanks!

Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments inline, plus one question (already asked in IRC):

https://github.com/bitcoinops/bitcoinops.github.io/pull/372/files#diff-96058f7a7c88130ae0773bd17e1a4dc3R39 links to the scaling book before we've announced it. Is everyone ok with that? If so, should we remove https://bitcoinops.org/en/scaling/fee-bumping/ until I've fixed the todos?

inefficiency now reduces the number of changes that need to be made in the
proposed schnorr, taproot, and tapscript soft fork. For more
information, see the Bitcoin Core PR Review Club [meeting notes][club
#16902] about this PR and a [related PR][Bitcoin Core #18002] also
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I parsed this sentence as "see (the Review Club meeting about this PR) and a related PR" instead of "see the Review Club meeting about (this PR and a related PR)". I suggest removing "and a related PR also merged this week". I don't think it's critical information that the Review Club also covered another refactor PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

merged this week.

- [LND #3821][] adds [anchor commitments][topic anchor outputs] for
LN channels and enables it by default if both participating nodes of a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure 'it' is correct here. It refers to "anchor commitments" which is plural, so suggests to me that we should use 'them'. Alternatively, "LND 3821 implements anchor commitments for enables this feature for new LN channels by default ..." or similar

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, was about to suggest s/it/this feature/

@jnewbery
Copy link
Contributor

Pushed a commit to link to the github version of the scaling book

Copy link
Collaborator

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good newletter @harding! A few comments below. Question: what plans for the review club feature (and frequency)? Last week's coin selection sessions were well-attended and some interesting ideas generated.

generating a single onchain transaction, multiple payments will be
[combined into a single transaction][scaling payment batching] once every 10 minutes.

- **Bitstamp supports bech32:** Bitstamp users can now benefit from using native
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps hoist "deposits and withdrawals" to the bitstamp title for clear quick comparison to the derebit title while skim reading.

[news85 ln stuck]: /en/newsletters/2020/02/19/#c-lightning-3500
[coinbase batching blog]: https://blog.coinbase.com/coinbase-rolls-out-bitcoin-transaction-batching-5f6d09b8b045
[bitstamp bech32 blog]: https://www.bitstamp.net/article/weve-added-support-bech32-bitcoin-addresses-bitsta/
[deribit bech32 withdrawal tweet]: https://twitter.com/DeribitExchange/status/1234904442169851909
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to find a better link for this on deribit's blog but it seems to be down currently (which surely explains why the tweet is being used here instead).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There wasn’t anything on the blog when I looked (and it was up)

merged this week.

- [LND #3821][] adds [anchor commitments][topic anchor outputs] for
LN channels and enables it by default if both participating nodes of a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, was about to suggest s/it/this feature/


- [LND #3821][] adds [anchor commitments][topic anchor outputs] for
LN channels and enables it by default if both participating nodes of a
channel signal support. Anchor commitment transactions can be fee
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the changeset to verify that anchor commitments are auto-enabled if both participants signal support"; comment and code seems to be here, lines 1114-1126: https://github.com/lightningnetwork/lnd/pull/3821/files#diff-691ca64693e704fd2e5080998f3e640eR1114

commit to their on-chain feerate.

- [LND #3963][] adds detailed [documentation][lnd op safety] about how
to use LND safely.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a PR of truly high value to users that might be worth a bit more pizzazz here. FWIW I like the name "lnd Operational Safety Guidelines".

- [LND #3963][] adds detailed [documentation][lnd op safety] about how
to use LND safely.

- [Eclair #1319][] implements the same solution as described in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISTM the PR title or a short description could be useful here, e.g. Eclair #1319 "Funder reserve for future fee increase" or descriptive equivalent, before writing that it is the same solution as described in Newsletter #85.

inefficiency now reduces the number of changes that need to be made in the
proposed schnorr, taproot, and tapscript soft fork. For more
information, see the Bitcoin Core PR Review Club [meeting notes][club
#16902] about this PR and a [related PR][Bitcoin Core #18002] also
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

@jonatack
Copy link
Collaborator

(verified the links so far as well)

@jnewbery
Copy link
Contributor

@jonatack

Question: what plans for the review club feature (and frequency)?

Plan is one per month, on the second week, with a summary of the most interesting discussion over the previous month's meetings.

That gives the following schedule:

  • 1st week: no special section
  • 2nd week: Bitcoin Core PR Review Club
  • 3rd week: Changes to services and client software
  • 4th week: Selected Q&A from Bitcoin StackExchange

Let me know if you want to write some of the Bitcoin Core PR Review Club sections.

@bitschmidty bitschmidty force-pushed the 2020-03-18-newsletter branch from ddd689a to 12a854c Compare March 18, 2020 11:48
@bitschmidty bitschmidty merged commit e1551aa into bitcoinops:master Mar 18, 2020
@jonatack
Copy link
Collaborator

Plan is one per month, on the second week, with a summary of the most interesting discussion over the previous month's meetings.

Let me know if you want to write some of the Bitcoin Core PR Review Club sections.

Sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

newsletters Publishing/translating/editing newsletters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants